Skip to content

Add element that installs software needed for cardiff#26

Merged
jovial merged 9 commits intomasterfrom
rpm
Jul 1, 2020
Merged

Add element that installs software needed for cardiff#26
jovial merged 9 commits intomasterfrom
rpm

Conversation

@jovial
Copy link
Copy Markdown
Contributor

@jovial jovial commented Jan 9, 2020

Certain hardware vendors only provide RPMs (no repository) and in certain situations it is undesirable to setup a local package repository.

Certain hardware vendors only provide RPMs (no repository)
and in certain situations it is undesirable to setup a
local package repository.
Copy link
Copy Markdown

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pass a URL to the -p argument?

@jovial
Copy link
Copy Markdown
Contributor Author

jovial commented Jan 9, 2020

Can you pass a URL to the -p argument?

Unsure, but I was going to make another element that depends on this one to install RPMS. It was going to do this by appending RPMS to the environment variable. It is possible you might be able to something similar with pkg-map, see: https://ask.openstack.org/en/question/81171/diskimage-builder-and-installing-a-downloaded-rpm-package/

@jovial jovial changed the title (WIP) Add an element to install RPMs (WIP) Add element that installs software needed for cardiff Jan 9, 2020
jovial added 4 commits January 9, 2020 14:40
This is required from the memory benchmarks.
This only works on intel so is a separate element.
2020-01-10 11:26:36.076 | Copying hooks /opt/kayobe/src/stackhpc-image-elements/elements/ipa-extra-hardware-ram/install.d/10-ddr-timings
2020-01-10 11:26:36.080 | There is a duplicated hook in your elements: /finalise.d/99-remove-extra-packages
@jovial jovial changed the title (WIP) Add element that installs software needed for cardiff Add element that installs software needed for cardiff Jan 10, 2020
Copy link
Copy Markdown
Member

@oneswig oneswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that minor observation on leaving make installed.

set -eu
set -o pipefail

install-packages -e gcc
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can uninstall make as well, although I expect that's trivial in size compared to gcc.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly basing this off the ironic-agent element which brings in make as a transitive dependency and doesn't uninstall it:

https://github.com/openstack/diskimage-builder/blob/168127b60ac314c7226bb7e8bee758cb7911de59/diskimage_builder/elements/ironic-agent/finalise.d/99-remove-extra-packages#L19

probably best to build a package so that you only need the run time dependencies, but that could be improved at a later point in time.

@jovial jovial merged commit 40a47b4 into master Jul 1, 2020
@jovial jovial deleted the rpm branch July 1, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants