Fix container scanning script's docker image ls output #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a potential fragility in the container scanning script by switching from parsing docker image ls's tabular output to using the --format flag for machine-readable output. This is a great improvement for the script's reliability. I've added one suggestion to further simplify the code by removing an unnecessary intermediate file, which also prevents leaving temporary files in the working directory.
jackhodgkiss
approved these changes
Nov 25, 2025
dougszumski
approved these changes
Nov 27, 2025
dougszumski
pushed a commit
that referenced
this pull request
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker's standard tabular output isn't designed for scripting, so inevitably has broken builds
Fixed it by using proper output formatting
See broken fixed