refactor(player): reduce video player duplication - #546
Merged
Conversation
stackia
marked this pull request as ready for review
June 17, 2026 09:52
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-546.eastasia.1.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactors the web video player to reduce duplication without splitting the component into new modules or increasing the runtime surface area.
The duplicated active-slot load/autoplay path is now centralized, pending transition stop/cancel is handled in one helper, and video element listener registration is table-driven so add/remove stay in sync.
This also addresses the deferred slot cleanup review feedback from the previous seamless switching PR. When a completed seamless switch schedules the old slot to stop on the next animation frame, that deferred stop is now tracked per slot and canceled before the slot is reused as a new pending slot. This preserves the RAF-based visual handoff while avoiding aborting a newly loaded pending stream.
src/embedded_web_data.his intentionally not included in this PR.Validation
pnpm exec biome check web-ui/src/components/player/video-player.tsxpnpm run type-check:tscpnpm exec vite build web-uigit diff --check