test(e2e): stabilize RTSP user-agent config checks#624
Merged
Conversation
Contributor
Documentation previewThe documentation preview has been deployed for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This narrows the RTSP user-agent configuration assertion in the E2E config suite. The test now uses an RTSP duration query to trigger OPTIONS and DESCRIBE, then verifies the upstream User-Agent header on both requests.
Why
The previous assertion used a full RTSP streaming request, so a transient SETUP, PLAY, or media forwarding timeout on the FreeBSD VM could fail the config-priority test before it ever checked the header. The new path still covers the configured User-Agent reaching the RTSP request layer, but avoids depending on full media playback.
Validation
Ran ruff, collect-only, focused config tests in serial and parallel, and the full E2E suite locally. Full E2E passed with 487 passed and 8 skipped.