feat(web): add installable app manifests#652
Merged
Merged
Conversation
Contributor
Documentation previewThe documentation preview has been deployed for this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds installable PWA support for the embedded status panel and web player by introducing Web App Manifests and updated icon metadata, with corresponding routing and E2E coverage.
Changes:
- Add manifest/icon/metadata links to
status.htmlandplayer.htmlfor installability. - Implement dynamic manifest generation/serving in the embedded web handler and route
/status.webmanifest+/player.webmanifestin the connection router. - Update packaging/docs references and add E2E tests covering prefixes, auth, root-path normalization, and config reload.
Reviewed changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web-ui/status.html | Adds manifest link + updated app/icon metadata for status page installability. |
| web-ui/player.html | Adds manifest link + updated app/icon metadata for player page installability. |
| src/embedded_web.h | Declares the new manifest handler API for embedded web. |
| src/embedded_web.c | Generates and serves Web App Manifest JSON dynamically (prefix/path/token aware). |
| src/connection.c | Routes manifest endpoints to the new handler. |
| scripts/build-ikuai-ipkg.sh | Updates packaged icon reference to the new 192px icon. |
| README.md | Updates README icon reference to the new 192px icon. |
| e2e/test_pages.py | Adds E2E coverage for manifest content, icons, prefixing, auth, root paths, and reload behavior. |
| docs/guide/web-player.md | Updates Chinese docs to reflect the new default installed-app name. |
| docs/en/guide/web-player.md | Updates English docs to reflect the new default installed-app name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm run lintpnpm run web-ui:buildcmake --build build -j$(getconf _NPROCESSORS_ONLN)pnpm run docs:build./scripts/run-e2e.sh -p 1 test_pages.py./scripts/run-e2e.sh -p 1 test_auth.py