fix: make sure trailing dot is present for targets of dns records (#73)

[stijzermans]

Implement a fix for issue #73, based on the implementation of:

https://github.com/kubernetes-sigs/external-dns/blob/066a11e2158f87689a01f0ff39493037da958171/provider/google/google.go#L427-L467

[ondbeh]

lgtm, except for the failing linter

[ondbeh]

Hi @stijzermans,

first of all - thank you for the contribution and sorry for getting back to you with a delay.

Can you please just fix the linting error from the test? I think in this case you can just add a lint ignore annotation.
I will in the meantime fix the Secret Scanner problem.

Since this change introduces a breaking change, we will take it as an opportunity to release version 1.0.0 of our webhook. For that, we have a few feature in mind that we would like to add. Therefore, in the meantime, I will create a pre-release with your contribution.

Thanks,
Ondřej

[stijzermans]

Hi @ondbeh - sorry for not checking the lint beforehand ;) Just added the ignore statement!

Nit: just merged back main into this branch, and I tried to use more static statements for record types in my implementation (i.e. endpoint.RecordTypeTXT) - and saw a new occurrence of "TXT" - let me know whatever is preferred and if you want me to revert these RecordType statements.

[ondbeh]

Hi @stijzermans
Thanks for the fix.
I think it makes more sense done this way, thank you - I will try to make a few more cleanups like this before the official 1.0.0 release.