Skip to content

chore(serverbackup): switch to new sdk structure#1485

Merged
SerseusWasTaken merged 2 commits into
mainfrom
chore/sdk-migration-serverbackup
Jul 22, 2026
Merged

chore(serverbackup): switch to new sdk structure#1485
SerseusWasTaken merged 2 commits into
mainfrom
chore/sdk-migration-serverbackup

Conversation

@rubenhoenle

Copy link
Copy Markdown
Member

Description

relates to STACKITCLI-354

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle
rubenhoenle requested a review from a team as a code owner July 21, 2026 09:48
@rubenhoenle
rubenhoenle force-pushed the chore/sdk-migration-serverbackup branch 2 times, most recently from f603c6f to 678c70e Compare July 21, 2026 10:27
Comment thread internal/cmd/server/backup/list/list.go Outdated
Comment thread internal/pkg/services/serverbackup/client/client.go Outdated
@rubenhoenle
rubenhoenle force-pushed the chore/sdk-migration-serverbackup branch from 678c70e to f14d6f3 Compare July 22, 2026 08:54
@SerseusWasTaken
SerseusWasTaken enabled auto-merge (squash) July 22, 2026 11:39
@SerseusWasTaken
SerseusWasTaken merged commit b7b504c into main Jul 22, 2026
3 checks passed
@SerseusWasTaken
SerseusWasTaken deleted the chore/sdk-migration-serverbackup branch July 22, 2026 11:44
@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/create 46.94% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/delete 46.88% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/describe 74.55% (+0.96%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/disable 31.82% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/enable 37.50% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/list 56.36% (-1.53%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/restore 55.26% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/create 50.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/delete 38.46% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/describe 72.92% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/list 61.67% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/update 62.71% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/volume-backup/delete 48.48% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/volume-backup/restore 52.78% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/utils 90.91% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/create/create.go 46.94% (ø) 49 23 26
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/delete/delete.go 46.88% (ø) 32 15 17
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/describe/describe.go 74.55% (+0.96%) 55 (+2) 41 (+2) 14 👍
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/disable/disable.go 31.82% (ø) 44 14 30
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/enable/enable.go 37.50% (ø) 40 15 25
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/list/list.go 56.36% (-1.53%) 55 (-2) 31 (-2) 24 👎
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/restore/restore.go 55.26% (ø) 38 21 17
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/create/create.go 50.00% (ø) 52 26 26
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/delete/delete.go 38.46% (ø) 39 15 24
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/describe/describe.go 72.92% (ø) 48 35 13
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/list/list.go 61.67% (ø) 60 37 23
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/update/update.go 62.71% (ø) 59 37 22
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/volume-backup/delete/delete.go 48.48% (ø) 33 16 17
github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/volume-backup/restore/restore.go 52.78% (ø) 36 19 17
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/utils/utils.go 90.91% (ø) 11 10 1

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/disable/disable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/enable/enable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/restore/restore_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/schedule/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/volume-backup/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/server/backup/volume-backup/restore/restore_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants