Generator: Update SDK /services/iaas#8613
Open
stackit-pipeline wants to merge 2 commits into
Open
Conversation
This was referenced Jul 14, 2026
rubenhoenle
reviewed
Jul 14, 2026
| ) | ||
|
|
||
| const ( | ||
| CreateSuccess = "CREATED" |
Member
There was a problem hiding this comment.
Do we still need these or can we use the generated enum values from the SDK?
rubenhoenle
reviewed
Jul 14, 2026
| } | ||
| if i.VPCNetworkRangeIPv4 != nil { | ||
| if i.VPCNetworkRangeIPv4.Status == nil { | ||
| return "", errors.New("status is missing in response") |
Member
There was a problem hiding this comment.
Suggested change
| return "", errors.New("status is missing in response") | |
| return "", errors.New("ipv4 status is missing in response") |
rubenhoenle
reviewed
Jul 14, 2026
| } | ||
| if i.VPCNetworkRangeIPv6 != nil { | ||
| if i.VPCNetworkRangeIPv6.Status == nil { | ||
| return "", errors.New("status is missing in response") |
Member
There was a problem hiding this comment.
Suggested change
| return "", errors.New("status is missing in response") | |
| return "", errors.New("ipv6 status is missing in response") |
rubenhoenle
reviewed
Jul 14, 2026
| } | ||
| if i.VPCNetworkRangeIPv4 != nil { | ||
| if i.VPCNetworkRangeIPv4.Status == nil { | ||
| return "", errors.New("status is missing in response") |
Member
There was a problem hiding this comment.
Suggested change
| return "", errors.New("status is missing in response") | |
| return "", errors.New("ipv4 status is missing in response") |
Same here. Maybe it would make sense to define a own private function to to get the VPC Network range state which you can re-use in the createOrUpdateNetworkRangeWaitHandler and the DeleteVPCNetworkRangeWaitHandler implementations. It's currently duplicated logic.
Member
There was a problem hiding this comment.
You could in theory do the same for the VPC Region wait handlers. But that's really just a nitpick, do it as you want m8 😊
rubenhoenle
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated from GitHub run 29342540531
spec comparison: stackitcloud/stackit-api-specifications@2215407...f05986b