Skip to content

feat(ske): onboard alb extension for cluster - #1631

Merged
Manuelvaas merged 8 commits into
mainfrom
feat/ske-onboard-alb-extension
Aug 4, 2026
Merged

feat(ske): onboard alb extension for cluster#1631
Manuelvaas merged 8 commits into
mainfrom
feat/ske-onboard-alb-extension

Conversation

@Manuelvaas

@Manuelvaas Manuelvaas commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

relates to STACKITTPR-769

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Manuelvaas
Manuelvaas requested a review from a team as a code owner July 30, 2026 08:01
@Manuelvaas
Manuelvaas force-pushed the feat/ske-onboard-alb-extension branch from cad31cc to 9a86a06 Compare August 3, 2026 11:42
Comment thread stackit/internal/services/ske/cluster/resource_test.go Outdated
@Manuelvaas
Manuelvaas enabled auto-merge (squash) August 4, 2026 11:32
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster 48.56% (+0.19%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource.go 50.59% (+0.15%) 933 (+21) 472 (+12) 461 (+9) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go

@Manuelvaas
Manuelvaas merged commit 7b66012 into main Aug 4, 2026
3 checks passed
@Manuelvaas
Manuelvaas deleted the feat/ske-onboard-alb-extension branch August 4, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants