fix(skills): update trailofbits/skills to cfe5d7b, fix zeroize-audit#740
Open
JAORMX wants to merge 3 commits into
Open
fix(skills): update trailofbits/skills to cfe5d7b, fix zeroize-audit#740JAORMX wants to merge 3 commits into
JAORMX wants to merge 3 commits into
Conversation
…onstant-time-analysis,differential-review,fp-check,insecure-defaults,property-based-testing,sarif-parsing,semgrep,semgrep-rule-creator,semgrep-rule-variant-creator,sharp-edges,supply-chain-risk-auditor,variant-analysis,yara-rule-authoring,zeroize-audit
Scanner flagged two list-form subprocess.run() calls (generate_poc.py, check_rust_asm.py) as dangerous. Neither uses shell=True or takes attacker-controlled arguments -- fixed commands/scripts, one with an explicit timeout. Note: the other 5 skills bumped in this digest (agentic-actions-auditor, codeql, constant-time-analysis, sharp-edges, yara-rule-authoring) still fail skill-security-scan due to the known scanner meta-analyzer JSON-parse bug (dozens to hundreds of raw findings surviving as blocking) -- not fixed here, not practically allowlistable by hand. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
🛡️ Skill Security Scan Results✅ agentic-actions-auditor
❌ codeql
Blocking issues:
❌ constant-time-analysis
Blocking issues:
✅ differential-review
✅ fp-check
✅ insecure-defaults
✅ property-based-testing
✅ sarif-parsing
✅ semgrep
✅ semgrep-rule-creator
✅ semgrep-rule-variant-creator
❌ sharp-edges
Blocking issues:
Allowlisted (not blocking):
✅ supply-chain-risk-auditor
✅ variant-analysis
❌ yara-rule-authoring
Blocking issues:
✅ zeroize-audit
Summary: Scanned 16 skill(s), found 647 blocking issue(s).
|
samuv
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill-security-scan.zeroize-audit: allowlistedBEHAVIOR_EVAL_SUBPROCESS— verified against the actual upstream source, both flaggedsubprocess.run()calls are list-form (noshell=True) with fixed commands/scripts and no attacker-controlled arguments.Not fixed here
The other 5 skills bumped in this digest (
agentic-actions-auditor,codeql,constant-time-analysis,sharp-edges,yara-rule-authoring) still failskill-security-scan. Their logs showFailed to parse meta-analysis response: No valid JSON found in response, the known scanner meta-analyzer bug — dozens to hundreds of raw pattern-match findings survive as blocking when this happens, which isn't practically fixable by hand-allowlisting. This is a scanner tooling reliability issue, not a dockyard content problem.Test plan
dockhandlocally, ranvalidate-skillagainstskills/zeroize-audit/spec.yaml—Status: VALIDzeroize-auditto go green, the other 5 to remain red pending the scanner bugCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com