Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment was marked as outdated.
This comment was marked as outdated.
PR #788 (Update stacklok/toolhive to v0.24.0) failed the run when skill_review hit the 30-turn cap mid-edit. Details from run 24786157448: - skill_gen: 67 turns / $4.72 (under 500 cap) -- succeeded, committed `42267da Document local vMCP CLI mode` - skill_review: 31 turns / $1.86 -- exited with subtype `error_max_turns`, cascading workflow to `failure`, which skipped autofix and PR body augmentation My initial cap of 30 for review was sized against silent/no- changes releases (4-6 turns baseline). For a real multi-file content review the editorial pass walks each edited file and makes tightening edits; ~30-100 turns is legitimate working range. Changes: - skill_review: 30 -> 200 (2x-6x headroom over working range) - skill_gen: 500 -> 1000 (defensive doubling; 500 was never hit in production, but 1000 keeps us well clear of the 397-turn v3-test anomaly) Hitting either cap still produces a loud failure; raise deliberately if a release genuinely needs more. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR #788's skill run committed SUMMARY.md to the branch alongside its content commit (42267da) because /SUMMARY.md isn't in .gitignore -- `git add -A` during claude-code-action's auto-commit swept it up. The workflow's signals step reads and removes SUMMARY.md, but only from the working tree; the commit that added it sticks around. /GAPS.md and /NO_CHANGES.md are already gitignored for exactly this reason; SUMMARY.md was added in #785 but I missed adding the matching gitignore entry. With this in place, claude-code-action's `git add -A` will skip SUMMARY.md, the skill still writes it to disk, the signals step still reads + deletes it -- no commit involvement at all, which is how GAPS.md and NO_CHANGES.md already work. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fa0212b to
70ed1d8
Compare
|
Claude finished @rdimitrov's task in 5m 26s —— View job Upstream release docs: toolhive v0.24.0Done. All six phases completed; pushed as commit
What shippedThe release's one documentation-impacting change was PR #5001 -
Skipped
NotesLocal |
Document thv vmcp serve/validate/init, which was unhidden in upstream PR #5001. Add a new guide covering quick mode, config-file mode, optimizer tiers, and a comparison to the Kubernetes VirtualMCPServer path. Update vMCP intro, index, and concept pages to surface the local CLI alongside the operator-based deployment.
|
Claude finished @rdimitrov's task in 3m 58s —— View job Editorial review: toolhive v0.24.0 docsDone. Pushed as commit
Findings and fixesTwo primary issues, both in
Not flagged
Third-person phrasing in · Branch · |
Point the "production" cross-link at the vMCP-specific quickstart instead of the general operator quickstart. Also tighten the optimizer-tier intro so Tier 1 (FTS5 keyword only) is not described as hybrid search. Co-authored-by: Radoslav Dimitrov <undefined@users.noreply.github.com>
|
@claude the local mode of vMCP is a secondary workflow for individual users and local testing; Kubernetes based deployment should be considered primary. The current positioning above k8s in the intro isn't ideal, and the new guide's position in the sidebar right after the quickstart feels like it interrupts the primary user journey. |
|
Claude finished @danbarr's task in 1m 40s —— View job Repositioning local vMCP CLI as secondary workflow
Changes made
|
Move local-cli sidebar entry to end of vMCP section; reorder index.mdx "Where to start" so K8s quickstart comes before local CLI; reframe intro.mdx to remove implication that local is a first step toward K8s. Co-authored-by: Dan Barr <danbarr@users.noreply.github.com>
Signed-off-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
This PR contains the following updates:
v0.23.1→v0.24.0After this PR opens,
.github/workflows/upstream-release-docs.ymladds source-verified content edits for the new release. Forstacklok/toolhive, the same workflow also syncs reference assets (CLI help, Swagger) and regenerates the CRD MDX pages.Release Notes
stacklok/toolhive (stacklok/toolhive)
v0.24.0Compare Source
What's Changed
Full Changelog: stacklok/toolhive@v0.23.1...v0.24.0
Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Docs update for
toolhivev0.24.0At a glance
stacklok/toolhivev0.23.1→v0.24.0Summary of changes
Summary of changes
docs/toolhive/guides-vmcp/local-cli.mdx: a new guide for running vMCPlocally via
thv vmcp serve/validate/init, covering quick mode vs.config-file mode, optimizer tiers 0-3,
--enable-audit, full flag tables, anda comparison to the Kubernetes
VirtualMCPServerCRD path.docs/toolhive/guides-vmcp/intro.mdxanddocs/toolhive/guides-vmcp/index.mdxso the entry points surface the newlocal CLI option alongside the existing Kubernetes deployment.
docs/toolhive/concepts/vmcp.mdxso the concept page acknowledgesboth delivery modes (operator CRD and CLI) and links to the local guide.
sidebars.tsto list the newlocal-cliguide under Virtual MCPServer, immediately after the Kubernetes quickstart.
Run cost
How this PR was built
Two Claude Opus sessions run per release: a generation pass
(
upstream-release-docsskill, 6 phases) followed by a fresh-context editorial pass (
docs-review). Prettier/ESLintauto-fixes are applied after.
Auto-synced paths — do not hand-edit these in review:
docs/toolhive/reference/cli/docs/toolhive/reference/crds/static/api-specs/If a "Gaps needing human context" section is present above,
each entry includes a paste-ready Helper prompt for local
Claude a reviewer can use to resolve the gap.