Fix Homebrew tap-trust breakage in libkrun install steps#100
Merged
Conversation
Homebrew 6.0 requires explicit trust for third-party taps before installing formulae from them. Trust the whole slp/krun tap rather than qualifying only the top-level formulae, since libkrun/libkrunfw pull in other tap formulae (e.g. virglrenderer) as dependencies that also need trust.
jhrozek
force-pushed
the
fix/homebrew-tap-trust
branch
from
1292b49 to
ea6a7c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slp/krun) now fails withRefusing to load formula ... from untrusted tapunless the tap or formula is explicitly trusted first.Build (macOS CGO)in CI (macos-15 runners picked up Homebrew 6.0) and will break local dev setup on any machine with an up-to-date Homebrew.slp/krun/libkrun,slp/krun/libkrunfw), which Homebrew treats as trusting only those specific items rather than the whole tap -- the CI-preferred minimal-trust pattern per Homebrew's own docs..github/workflows/ci.yaml,.github/workflows/release.yaml, and the doc references indocs/MACOS.md,README.md,CONTRIBUTING.md, andCLAUDE.md.Why separate from PR #99
PR #99 (OCI symlink extraction fix) is currently blocked by this same CI failure on an unrelated file. Landing this fix on
mainfirst unblocks that PR without mixing an infra fix into its diff.Test plan
Build (macOS CGO)passes on this PRBuild (macOS CGO)goes green there too🤖 Generated with Claude Code