-
Notifications
You must be signed in to change notification settings - Fork 203
Fix API group mismatch in operator webhook manifest for MCPExternalAuthConfig #4599
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingkubernetesItems related to KubernetesItems related to Kubernetesoperator
Description
Summary
The MCPExternalAuthConfig webhook entry in cmd/thv-operator/config/webhook/manifests.yaml uses the wrong API group toolhive.stacklok.com instead of the correct toolhive.stacklok.dev. The webhook path also uses toolhive-stacklok-com instead of toolhive-stacklok-dev.
The other two webhooks in the same file and the top-level config/webhook/manifests.yaml all correctly use toolhive.stacklok.dev.
Impact
- Latent bug that would surface if webhooks were ever enabled
- Would target a non-existent API group, causing the webhook to silently not fire
Location
cmd/thv-operator/config/webhook/manifests.yamllines 13 and 18
Fix
Change toolhive.stacklok.com to toolhive.stacklok.dev in the apiGroups rule, and update the path from toolhive-stacklok-com to toolhive-stacklok-dev.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingkubernetesItems related to KubernetesItems related to Kubernetesoperator