Fix API group mismatch in operator webhook manifest#4600
Merged
ChrisJBurns merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
The MCPExternalAuthConfig webhook entry in the operator's webhook manifest incorrectly used `toolhive.stacklok.com` for both the API group and the webhook path. The correct API group is `toolhive.stacklok.dev`, which is what the other two webhooks in the same file and the top-level manifest already use. Fixes #4599 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisJBurns
requested review from
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
==========================================
- Coverage 68.90% 68.83% -0.08%
==========================================
Files 505 505
Lines 52403 52403
==========================================
- Hits 36109 36071 -38
- Misses 13502 13542 +40
+ Partials 2792 2790 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCPExternalAuthConfig webhook entry in
cmd/thv-operator/config/webhook/manifests.yamlincorrectly used the API grouptoolhive.stacklok.cominstead of the correcttoolhive.stacklok.dev. The webhook path also used the wrong domain (toolhive-stacklok-cominstead oftoolhive-stacklok-dev). The other two webhooks in the same file and the top-levelconfig/webhook/manifests.yamlalready used the correct group. This is a latent bug that would cause the webhook to target a non-existent API group if webhooks were ever enabled.Fixes #4599
Type of change
Test plan
toolhive.stacklok.devconfig/webhook/manifests.yamlwas already correct and unchangedtoolhive.stacklok.devpergroupversion_info.goGenerated with Claude Code