Skip to content

Fix proposal naming validation to only check new files #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JAORMX merged 1 commit into from
Nov 27, 2025
Merged

Fix proposal naming validation to only check new files #2788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/validate-proposal-naming.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,13 @@ jobs:

- name: Validate proposal naming
run: |
# Get the list of changed files in docs/proposals
CHANGED_FILES=$(git diff --name-only --diff-filter A origin/${{ github.base_ref }}...HEAD | grep '^docs/proposals/')
# Get the list of NEW files added in docs/proposals (not modifications to existing files)
CHANGED_FILES=$(git diff --name-only --diff-filter=A origin/${{ github.base_ref }}...HEAD | grep '^docs/proposals/' || true)

# This is here to avoid errors when running this workflow manually without a PR
# Skip validation if no new proposal files are being added
# (modifications to existing proposals don't need naming validation)
if [ -z "$CHANGED_FILES" ]; then
echo "ℹ️ No proposal files changed in this PR"
echo "ℹ️ No new proposal files added in this PR (only modifications to existing proposals or manual trigger)"
exit 0
fi

Expand Down
Loading