Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/vmcp/config/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ func (v *DefaultValidator) validateIncomingAuth(auth *IncomingAuthConfig) error
return fmt.Errorf("incoming_auth.oidc.audience is required")
}

// Client secret env var should be set (references a Kubernetes Secret mounted as env var)
if auth.OIDC.ClientSecretEnv == "" {
return fmt.Errorf("incoming_auth.oidc.client_secret_env is required")
}
// ClientSecretEnv is optional - some OIDC flows don't require client secrets:
// - PKCE flows (public clients)
// - Token validation without introspection
// - Kubernetes service account token validation
}

// Validate authorization configuration
Expand Down
12 changes: 12 additions & 0 deletions pkg/vmcp/config/validator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,18 @@ func TestValidator_ValidateIncomingAuth(t *testing.T) {
},
wantErr: false,
},
{
name: "valid OIDC auth without client secret (public client)",
auth: &IncomingAuthConfig{
Type: "oidc",
OIDC: &OIDCConfig{
Issuer: "https://example.com",
ClientID: "public-client",
Audience: "vmcp",
},
},
wantErr: false,
},
{
name: "invalid auth type",
auth: &IncomingAuthConfig{
Expand Down
Loading