Fix CI extraVolumes test using wrong value keys#4607
Merged
Conversation
The CI test file used operator.extraVolumeMounts and operator.extraVolumes, but the deployment template reads operator.volumeMounts and operator.volumes. This mismatch meant the CI test silently passed without actually exercising volume injection. Rename the keys to match what the template expects. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisJBurns
requested review from
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
==========================================
- Coverage 68.87% 68.86% -0.02%
==========================================
Files 505 505
Lines 52420 52420
==========================================
- Hits 36106 36098 -8
- Misses 13521 13531 +10
+ Partials 2793 2791 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI test file
deploy/charts/operator/ci/extraVolumes-values.yamlusedoperator.extraVolumeMountsandoperator.extraVolumes, but the deployment template reads.Values.operator.volumeMountsand.Values.operator.volumes. This key mismatch meant the CI test silently passed without actually exercising volume injection, giving false confidence that volumes work correctly.Renamed the keys to match what the template and
values.yamlexpect.Type of change
Test plan
values.yamldefinesoperator.volumesandoperator.volumeMounts(notextraVolumes/extraVolumeMounts)deployment.yamltemplate reads.Values.operator.volumeMountsand.Values.operator.volumesGenerated with Claude Code