Preserve inner error codes through the skills lock-state wrap#5966
Open
samuv wants to merge 1 commit into
Open
Preserve inner error codes through the skills lock-state wrap#5966samuv wants to merge 1 commit into
samuv wants to merge 1 commit into
Conversation
installAndRegister wrapped every recordLockState failure as HTTP 500, but dependency materialization runs inside recordLockState — so a dependency's specific failure (502 from a git resolve, 404 from a registry miss) was masked at the API boundary and classified as "unknown" instead of its typed sync failure reason. Attach 500 only when the inner chain carries no code; code-less failures such as an actual lock write error keep defaulting to 500. Deferred follow-up from the #5894 panel review.
15 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5966 +/- ##
==========================================
+ Coverage 71.85% 71.89% +0.03%
==========================================
Files 714 715 +1
Lines 73415 73502 +87
==========================================
+ Hits 52755 52846 +91
+ Misses 16879 16872 -7
- Partials 3781 3784 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installAndRegisterwrapped everyrecordLockStatefailure as HTTP 500 — but dependency materialization runs insiderecordLockState, so a dependency's specific failure (502 from a git resolve, 404 from a registry miss) was masked to 500 at the API boundary, andclassifySyncFailurereportedunknowninstead of the typed reason (registry-unreachable/digest-missing) that CI automation keys on.httperrcode. Code-less failures — e.g. an actual lock file write error — keep defaulting to 500, and theerrLockWritesentinel classification is unchanged.Type of change
Test plan
Install(was 500 before the fix)task testandtask lint-fixpass locally🤖 Generated with Claude Code