Bump toolhive-core for tool-schema ingestion fix#5990
Merged
Conversation
The §12 tool-schema ingestion fidelity fix landed upstream in stacklok/toolhive-core#186 (ToolArgumentsSchema now preserves top-level JSON Schema keywords like oneOf/anyOf via an Extra catch-all and stops fabricating an empty "type"). Bump toolhive-core to pick it up and unskip the in-repo gate added in #5977, closing the ToolHive half of #5976. The dependency is pinned to the exact #186 commit rather than to toolhive-core main HEAD: HEAD also carries #185 (adopt go-sdk v1.7.0-pre.3), a 2026-07-28 groundwork change tracked separately under #5754 and out of scope here. Re-pin to a tagged release (v0.0.34+) once one is cut that includes #186. - go.mod/go.sum: toolhive-core v0.0.32 -> #186 commit (plus minor transitive aws-sdk patch bumps). - Remove the t.Skip on TestRegression_ToolSchemaFidelity_PreservesCompositors; it now passes, pinning backend->vMCP ingestion of a top-level oneOf and the absence of a fabricated "type":"". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WG3mSjVGWNc8nfgbkdd79
JAORMX
requested review from
ChrisJBurns,
amirejaz,
jerm-dro,
jhrozek and
tgrunnagle
as code owners
July 25, 2026 13:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5990 +/- ##
==========================================
+ Coverage 71.99% 72.02% +0.03%
==========================================
Files 717 717
Lines 73977 73977
==========================================
+ Hits 53257 53284 +27
+ Misses 16918 16874 -44
- Partials 3802 3819 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jerm-dro
approved these changes
Jul 25, 2026
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5976. Part of #5743.
The §12 tool-schema ingestion fidelity defect — backend→vMCP ingestion silently dropping top-level JSON Schema keywords (
oneOf/anyOf/allOf/enum) and fabricating an empty"type":""— was fixed upstream in stacklok/toolhive-core#186 (ToolArgumentsSchemanow preserves unmodeled top-level keywords via anExtracatch-all and emits"type"only when set). This bumpstoolhive-coreto pick up that fix and unskips the in-repo gate added in #5977, closing the ToolHive half of #5976.go.mod/go.sum:toolhive-core v0.0.32→ the refactor: remove unused response channel #186 commit (plus minor transitiveaws-sdk-go-v2patch bumps that come with it).t.SkiponTestRegression_ToolSchemaFidelity_PreservesCompositors(pkg/vmcp/client/schema_ingestion_regression_test.go); it now passes, pinning that a backend tool schema with a top-leveloneOfis projected throughListCapabilities→ConvertToolInputSchemaintact and gains no fabricated"type":"".Type of change
Test plan
task test)task lint-fix)TestRegression_ToolSchemaFidelity_PreservesCompositorsflips from skipped to passing. Fulltask testis green except three pre-existing, environment-only failures unrelated to this change (no container runtime / no keyring in the sandbox), none in the touched packages.Special notes for reviewers
toolhive-coremain HEAD. HEAD also carries authz: Enhance Cedar authorization framework #185 (adopt go-sdkv1.7.0-pre.3) — the 2026-07-28 "stateless" groundwork tracked separately under Adopt go-sdk v1.7 for MCP 2026-07-28 stateless support #5754 and deliberately out of scope here. This bump brings no go-sdk /modelcontextprotocolversion change (verify the go.mod diff).v0.0.33, cut before it), the dependency is a pseudo-version (v0.0.34-0.20260724…-e86653447aee). Please re-pin to a tagged release (v0.0.34+) once one is cut that includes refactor: remove unused response channel #186 — happy to follow up with that one-line change.🤖 Generated with Claude Code