Adopt telemetry providers from toolhive-core - #6146
Open
JAORMX wants to merge 1 commit into
Open
Conversation
JAORMX
requested review from
ChrisJBurns,
amirejaz,
aponcedeleonch,
jerm-dro,
jhrozek,
rdimitrov and
reyortiz3
as code owners
July 30, 2026 14:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6146 +/- ##
==========================================
- Coverage 72.61% 72.49% -0.12%
==========================================
Files 736 729 -7
Lines 76340 76013 -327
==========================================
- Hits 55431 55107 -324
- Misses 16973 16999 +26
+ Partials 3936 3907 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 3 adoption: delete
pkg/telemetry/providers(~2,900 LOC incl. tests) and consumetoolhive-core/telemetry/providers(v0.0.37, stacklok/toolhive-core#204 — a verbatim graduation of this same tree).Changes:
pkg/telemetry/config.go: import path swap — the option API (WithServiceName,WithOTLPEndpoint, …,NewCompositeProvider) is identical, so no call-site changespkg/telemetry/providers/: deletedtest/e2e/dual_era_observability_test.goWhat stays in toolhive (unchanged): the CRD-coupled
telemetry.Config, MCP middleware, serve, propagation, attributes.Test plan
task build,task lint-fix— cleango test ./pkg/telemetry/...— pass (note:cmd/thv-operator/test-integrationfails locally on missing envtest binaries, pre-existing env issue; CI has them)