fix(operator): warn when VirtualMCPServer inline telemetry is ignored - #6408
Merged
blkt merged 4 commits intoSep 2, 2026
Merged
Conversation
RaviTharuma
requested review from
ChrisJBurns,
JAORMX,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
August 21, 2026 09:36
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6408 +/- ##
==========================================
+ Coverage 78.13% 78.17% +0.03%
==========================================
Files 768 768
Lines 74649 74660 +11
==========================================
+ Hits 58324 58362 +38
+ Misses 16320 16293 -27
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
blkt
reviewed
Aug 24, 2026
cursor
Bot
force-pushed
the
fix/vmcp-inline-telemetry-warning
branch
from
August 30, 2026 13:02
fc67cfa to
c25df52
Compare
Signed-off-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
Review asked emitInlineTelemetryIgnoredEvent to take only the VirtualMCPServer and evaluate Spec.Config.Telemetry and Spec.TelemetryConfigRef inside the helper. Co-authored-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/vmcp-inline-telemetry-warning
branch
from
September 2, 2026 10:21
c25df52 to
102a76a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the operator-managed VirtualMCPServer footgun where spec.config.telemetry is ignored by documenting the behavior and emitting a Warning event (InlineTelemetryIgnored) when inline telemetry is set without spec.telemetryConfigRef, helping users understand why /metrics is not registered (and scrapes hit the MCP handler with HTTP 406).
Changes:
- Add a one-shot-style Warning event emission path in the VirtualMCPServer reconciler for ignored inline telemetry.
- Update operator and general observability docs to state that inline telemetry is an operator no-op for VirtualMCPServer and to describe the 406 scrape symptom.
- Add unit test coverage for the new event emission behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/operator/virtualmcpserver-observability.md | Updates vMCP operator observability docs to explain inline telemetry is ignored and that the operator emits a warning. |
| docs/observability.md | Updates general observability docs to distinguish inline telemetry behavior across resource types, including vMCP operator no-op. |
| cmd/thv-operator/controllers/virtualmcpserver_vmcpconfig.go | Emits the inline-telemetry-ignored Warning during VMCP config reconciliation. |
| cmd/thv-operator/controllers/virtualmcpserver_controller.go | Adds emitInlineTelemetryIgnoredEvent helper for Warning event emission. |
| cmd/thv-operator/controllers/virtualmcpserver_controller_test.go | Adds unit tests for the new Warning event emission behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The unit-test job failed on TestUpstreamTokenRefresher_RowIdentity, which this PR does not touch. Retrigger so required checks can go green. Co-authored-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
Contributor
Author
|
@blkt the nit is in (emitInlineTelemetryIgnoredEvent takes only vmcp and computes usesIgnoredInline internally). Thread is resolved. Please re-review. |
Document that the event is not strictly one-shot, drop the 50ms timeout from the recorder test, and stop claiming CEL rejects inline telemetry plus telemetryConfigRef.
ChrisJBurns
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #6276 after closing #6277. Operator ignores spec.config.telemetry and emits a one-shot Warning (InlineTelemetryIgnored) when it is set without telemetryConfigRef. Docs no longer claim inline still works for operator vMCP. /metrics stays unregistered without the ref (HTTP 406).