Skip to content

incident-readiness rules to reflect changes in the framework definition - #14

Merged
prasoonanand124 merged 3 commits into
mainfrom
feat/incident-readiness-hybrid
Aug 1, 2026
Merged

incident-readiness rules to reflect changes in the framework definition#14
prasoonanand124 merged 3 commits into
mainfrom
feat/incident-readiness-hybrid

Conversation

@prasoonanand124

@prasoonanand124 prasoonanand124 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

incident-readiness rules to reflect changes in the framework definition.
Moved 2 Mandatory checks to recommended

Type

Select all that apply:

  • Check / catalog YAML (packages/aprf-engine/rules/)
  • Published spec (spec/aprf-spec.json) or JSON schemas
  • Engine / framework package code
  • Auditor skill (skills/aprf-auditor/)
  • Docs / RFC / governance
  • CI / tooling

Test plan

  • npm run validate
  • npm run build
  • Other:

Checklist

Always

  • CI-equivalent checks pass locally (npm run validate at minimum)
  • Focused PR (one concern when practical); RFC linked if normative semantics change
  • [Unreleased] in CHANGELOG.md updated when user-visible

If Check YAML changed

  • Regenerated and committed packages/aprf-engine/src/generated/catalog.ts (npm run aprf:catalog)
  • Spec synced where catalog is SoT (spec/aprf-spec.json method / requirement / passCondition as needed)
  • No reused Check IDs; deprecations use replacedBy
  • Titles keep obligation language (must / should / must have / should have); no ... / truncation

Scope

  • Product-only / cloud-vendor detectors and live API clients stay out of normative Check YAML (portable auditor collectors under skills/aprf-auditor/ are OK)

Comment thread skills/aprf-auditor/collectors/ai-containment-drill.ts Fixed
Comment thread skills/aprf-auditor/collectors/ai-customer-notification-criteria.ts Fixed
Comment thread skills/aprf-auditor/collectors/ai-incident-tabletop.ts Fixed
Comment thread skills/aprf-auditor/collectors/ai-safety-quality-alerts.ts Fixed
Comment thread skills/aprf-auditor/collectors/incident-playbooks.ts Fixed
Comment thread skills/aprf-auditor/collectors/post-incident-aprf-actions.ts Fixed
@prasoonanand124 prasoonanand124 added enhancement New feature or request and removed enhancement New feature or request labels Aug 1, 2026
prasoonanand124 and others added 2 commits August 1, 2026 07:45
Document the pre-release INC-M3/M4 demotion exception, tighten INC-R2/R3 collector PASS gates, and clear unused statusHint initializers.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@prasoonanand124

Copy link
Copy Markdown
Contributor Author

Review follow-ups

Addressed in 519f41c / fd25042:

  1. INC-M3/M4 deleted without deprecate stubs — Documented intentional pre-release exception (no tagged versions yet) in id-gaps.md and ratified by APRF-RFC-0002 (INC-M3→INC-R2, INC-M4→INC-R4). Linked from README / ARCHITECTURE / CONTRIBUTING / CHANGELOG.

  2. INC-R2 PASS without sev count — PASS now requires sevEligibleIncidentCount > 0 (omit → PARTIAL; 0 → N/A). Smoke updated.

  3. INC-R3 PASS without timestamps — PASS now requires timestampsPresent === true. Smoke updated.

  4. Useless statusHint assignment (code-quality) — Initializer removed on the six incident collectors; branches still assign explicitly.

Happy to tweak RFC wording if stewards want in-review instead of accepted for the 14-day window.

@prasoonanand124
prasoonanand124 merged commit 863dec9 into main Aug 1, 2026
6 checks passed
@prasoonanand124
prasoonanand124 deleted the feat/incident-readiness-hybrid branch August 1, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant