ROX-13692: fix final snapshot creation#1012
Conversation
| require.NoError(t, err) | ||
| assert.True(t, clusterDeleted) | ||
|
|
||
| // Always attemt to delete the final snapshot if it exists |
There was a problem hiding this comment.
| // Always attemt to delete the final snapshot if it exists | |
| // Always attempt to delete the final snapshot if it exists |
There was a problem hiding this comment.
Thanks, fixed it.
vladbologa
left a comment
vladbologa
left a comment
There was a problem hiding this comment.
Thanks for writing the E2E howto!
| - 'docs/**' | ||
| - 'pkg/api/openapi/docs/**' | ||
| - 'pkg/api/openapi/.openapi-generator-ignore' | ||
| - 'dp-terraform/**' |
There was a problem hiding this comment.
This might be useful. Some parameters used in terraform-cluster.sh (such as MANAGED_DB_SUBNET_GROUP) are also used in rds_test.go.
There was a problem hiding this comment.
AFAIK those parameters are not directly defined in terraform-cluster.sh but loaded from AWS parameterstore/secretsmanager so that shouldn't be a problem. I'm concerned about having to run this now even more time consuming test and not beeing able to skip it as "not admin" of this git repo during a release process.
| _, err := r.rdsClient.DeleteDBCluster(newDeleteCentralDBClusterInput(clusterID, false)) | ||
| if err != nil { | ||
| if awsErr, ok := err.(awserr.Error); ok { | ||
| // This assumes that if a final snapshot exists, a deletion for the RDS cluster was already trigger |
There was a problem hiding this comment.
| // This assumes that if a final snapshot exists, a deletion for the RDS cluster was already trigger | |
| // This assumes that if a final snapshot exists, a deletion for the RDS cluster was already triggered |
| # At some point your central instance should become ready | ||
| ``` | ||
|
|
||
| 1. Make sure DB state is available and 2 instances exist in state available |
There was a problem hiding this comment.
Nit: and Central is ready too
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
3 participants
The first PR #994 was causing errors in the stage environment because the reconciler would proceed to run delete DB calls to AWS even though the deletion was already in progress. The ad-hoc fix for staging was to revert the PR. This PR is the new attempt to implement the feature without breaking reconciliation logic.
Description
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
See the new file
howto-e2e-test-rds.md.Also running local RDS integration tests.