Add additional argoCD parameters for Central CRs#2091
Merged
Conversation
ludydoo
commented
Nov 14, 2024
| "telemetryStorageEndpoint": r.telemetry.StorageEndpoint, | ||
| "centralAdminPasswordEnabled": !r.wantsAuthProvider, | ||
| "centralDbSecretName": centralDbSecretName, | ||
| "tenant": map[string]interface{}{ |
Contributor
Author
There was a problem hiding this comment.
I will be removing the tenant parameter in favor of a flatter parameter structure. (e.g. prefer organizationName to tenant.organizationName)
kovayur
approved these changes
Nov 14, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("getting Central DB connection string: %w", err) | ||
| } | ||
| values["centralDbConnectionString"] = centralDBConnectionString |
Contributor
There was a problem hiding this comment.
How about moving additionalCAs logic here?
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
Contributor
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding required argoCD application parameters in preparation of moving Central CRs to ArgoCD
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts