Skip to content

chore: Update local setup doc#2104

Merged
kurlov merged 3 commits intomainfrom
akurlov/update-local-setup-doc
Jan 6, 2025
Merged

chore: Update local setup doc#2104
kurlov merged 3 commits intomainfrom
akurlov/update-local-setup-doc

Conversation

@kurlov
Copy link
Copy Markdown
Member

@kurlov kurlov commented Nov 27, 2024

Description

  • Update doc for local setup
  • Fix error makefile error if pre-commit is not install
  • Migrate deprecated pre-commit task

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

N/A

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jan 6, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 6, 2025

New changes are detected. LGTM label has been removed.

@kurlov kurlov merged commit 9e48a68 into main Jan 6, 2025
@kurlov kurlov deleted the akurlov/update-local-setup-doc branch January 6, 2025 15:15
johannes94 pushed a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants