Skip to content

Remove cluster actions from the cluster idp setup#2130

Merged
kovayur merged 1 commit intomainfrom
yury/remove-oc-from-idp-setup
Dec 18, 2024
Merged

Remove cluster actions from the cluster idp setup#2130
kovayur merged 1 commit intomainfrom
yury/remove-oc-from-idp-setup

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Dec 17, 2024

Description

Remove the cluster login and all cluster actions, such as creating a cluster role binding. The latter has been moved to the gitops configuration.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit bcd5b05 into main Dec 18, 2024
@kovayur kovayur deleted the yury/remove-oc-from-idp-setup branch December 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants