Skip to content

ROX-27129: remove tenant-resources helm chart#2131

Merged
ludydoo merged 1 commit intomainfrom
ROX-27129-remove-tenant-resources
Jan 17, 2025
Merged

ROX-27129: remove tenant-resources helm chart#2131
ludydoo merged 1 commit intomainfrom
ROX-27129-remove-tenant-resources

Conversation

@ludydoo
Copy link
Copy Markdown
Contributor

@ludydoo ludydoo commented Dec 18, 2024 •
edited
Loading

Description

Removing the tenant-resources helm chart.

This removes the logic branch where the reconciler could deploy the embedded tenant-resources helm chart, and assumes that ArgoCD is always enabled for tenants.

Also, the Network Policy Tests were coupled to the old tenant-resources helm chart, and had to be deleted along with the chart.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 18, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 18, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 18, 2024

/retest

1 similar comment
@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 18, 2024

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 18, 2024

@hector-vido: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e

/test images

Use /test all to run all jobs.

Details

In response to this:

/retest images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hector-vido
Copy link
Copy Markdown

hector-vido commented Dec 18, 2024

/test images

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 18, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

8 similar comments
@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 19, 2024

/retest

@hector-vido
Copy link
Copy Markdown

hector-vido commented Dec 19, 2024

/test images

@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Dec 20, 2024

/retest

@ludydoo ludydoo force-pushed the ROX-27129-remove-tenant-resources branch from e203f73 to 88952ee Compare January 13, 2025 10:57
@ludydoo
Copy link
Copy Markdown
Contributor Author

ludydoo commented Jan 15, 2025

/retest

@ludydoo ludydoo force-pushed the ROX-27129-remove-tenant-resources branch from 88952ee to dc1e7d4 Compare January 15, 2025 12:04
@ludydoo ludydoo requested review from johannes94 and kovayur January 15, 2025 13:32
kovayur
kovayur approved these changes Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kovayur kovayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

.openshift-ci/tests/e2e.sh
fi

FAIL=0
if ! "${GITROOT}/.openshift-ci/tests/netpol-test.sh"; then
Copy link
Copy Markdown
Contributor

@kovayur kovayur Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still need those tests? Are we going to move them to the gitops repository? How about creating a follow-up ticket?

Copy link
Copy Markdown
Contributor Author

@ludydoo ludydoo Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we still need them, but I can create a follow-up ticket.

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo ludydoo merged commit b08f1b1 into main Jan 17, 2025
@ludydoo ludydoo deleted the ROX-27129-remove-tenant-resources branch January 17, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kovayur kovayur kovayur approved these changes

@johannes94 johannes94 Awaiting requested review from johannes94

Assignees

@kovayur kovayur

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ludydoo @hector-vido @kovayur @openshift-merge-robot