Skip to content

Bump golang to 1.22#2134

Merged
kurlov merged 4 commits intomainfrom
akurlov/migrate-to-go-1.22
Jan 6, 2025
Merged

Bump golang to 1.22#2134
kurlov merged 4 commits intomainfrom
akurlov/migrate-to-go-1.22

Conversation

@kurlov
Copy link
Copy Markdown
Member

@kurlov kurlov commented Jan 2, 2025 •
edited
Loading

Description

Migrate to 1.22 golang
Note: ubi8/go-toolset support only 1.22.9 golang version ATM

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

make binary

@openshift-ci openshift-ci bot added the approved label Jan 2, 2025
@kurlov
Copy link
Copy Markdown
Member Author

kurlov commented Jan 3, 2025

/retest

@kurlov kurlov force-pushed the akurlov/migrate-to-go-1.22 branch from f5f9cc6 to a4ec9f6 Compare January 3, 2025 13:59
kurlov
kurlov commented Jan 3, 2025
View reviewed changes
go.mod
module github.com/stackrox/acs-fleet-manager

go 1.21.8
go 1.22.9
Copy link
Copy Markdown
Member Author

@kurlov kurlov Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubi8/go-toolset doesn't support 1.22.10

This was referenced Jan 3, 2025
Closed
Closed
kurlov
kurlov commented Jan 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@kurlov kurlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@kurlov
Copy link
Copy Markdown
Member Author

kurlov commented Jan 6, 2025

/retest

@openshift-ci openshift-ci bot added the lgtm label Jan 6, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit 9491844 into main Jan 6, 2025
@kurlov kurlov deleted the akurlov/migrate-to-go-1.22 branch January 6, 2025 10:49
johannes94 pushed a commit that referenced this pull request Jan 22, 2025
@kurlov @johannes94
Bump golang to 1.22 (#2134)
01a87f1 
* Bump golang to 1.22

* Change version to 1.22.9

* Update int for loops

* Fix TestEncyrptionSHASumSameObject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kovayur kovayur kovayur approved these changes

Assignees

@kovayur kovayur

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kurlov @kovayur