ROX-25966: Add tenantID to email from alias

[kurlov]

Description

Add tenantID to the email sender Alias to make it clear that email sent for specific instance

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
• Add secret to app-interface Vault or Secrets Manager if necessary
• RDS changes were e2e tested manually
• Check AWS limits are reasonable for changes provisioning new resources
• (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

N/A

[kurlov]

/retest

[kovayur]

Wouldn't it be more “user-friendly” to specify an instance name instead of an ID?

[kurlov]

Wouldn't it be more “user-friendly” to specify an instance name instead of an ID?

Yes, but it requires way more effort to allow emailsender read tenant labels or pass it via Central. TenantID is a simple way to show that email came from this particular instance

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [johannes94,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment