Skip to content

chore: skip OperatorGroup for openshift-logging if exists#2139

Merged
kurlov merged 1 commit intomainfrom
akurlov/skip-OperatorGroup-if-exists
Jan 7, 2025
Merged

chore: skip OperatorGroup for openshift-logging if exists#2139
kurlov merged 1 commit intomainfrom
akurlov/skip-OperatorGroup-if-exists

Conversation

@kurlov
Copy link
Copy Markdown
Member

@kurlov kurlov commented Jan 7, 2025

Description

Skip helm creating OperatorGroup for openshift-logging if it exists already to prevent FSS Addon reconciliation error

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

N/A

@kurlov kurlov requested a review from kovayur January 7, 2025 11:22
@openshift-ci openshift-ci bot added the approved label Jan 7, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov
Copy link
Copy Markdown
Member Author

kurlov commented Jan 7, 2025

/override ci/prow/e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 7, 2025

@kurlov: Overrode contexts on behalf of kurlov: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kurlov kurlov merged commit 118f299 into main Jan 7, 2025
@kurlov kurlov deleted the akurlov/skip-OperatorGroup-if-exists branch January 7, 2025 11:43
johannes94 pushed a commit that referenced this pull request Jan 22, 2025
Skip OperatorGroup for openshift-loggin if exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants