Merged
Conversation
kurlov
approved these changes
Jan 7, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Most likely the operator group on OSD is defined here: https://github.com/openshift/managed-cluster-config/blob/master/deploy/osd-logging/01-operatorgroup.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
OperatorGroup can't be added to the dp-terraform Helm chart, because it seems like it is created on OSD clusters by default and can't be managed (owned) by helm:
On the other hand, the operator is not installed on ROSA clusters and
OperatorGroupis required when you install an operator with manifests (kubectl, helm).Proposed solution
Move the problematic
OperatorGroupto an ArgoCD application for ROSA clusters.Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts