ROX-27129: cleanup central CR reconciliation logic#2149
Merged
Conversation
johannes94
approved these changes
Jan 17, 2025
Contributor
johannes94
left a comment
johannes94
left a comment
There was a problem hiding this comment.
Just a nitpick. Everything else looks good.
Base automatically changed from
ROX-27129-remove-central-field-from-reconciler
to
main
January 17, 2025 18:28
ludydoo
force-pushed
the
ROX-27129-remove-v1alpha1-central-from-reconciler-signatures
branch
from
0816df1 to
dfed617
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
ludydoo
force-pushed
the
ROX-27129-remove-v1alpha1-central-from-reconciler-signatures
branch
from
044d74b to
c3c1f33
Compare
ludydoo
force-pushed
the
ROX-27129-remove-v1alpha1-central-from-reconciler-signatures
branch
from
62755da to
4a6348f
Compare
ludydoo
changed the title
Contributor
Author
|
/retest |
ludydoo
deleted the
ROX-27129-remove-v1alpha1-central-from-reconciler-signatures
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes some
CentralReconcilermethod signatures to not accept av1alpha1.Central, but only aprivate.ManagedCentral. This is in prevision of the complete removal ofv1alpha1.Central