Skip to content

ROX-27073: github action for multicluster test#2158

Merged
johannes94 merged 6 commits intomainfrom
jmalsam/github-action-for-multicluster-test
Feb 11, 2025
Merged

ROX-27073: github action for multicluster test#2158
johannes94 merged 6 commits intomainfrom
jmalsam/github-action-for-multicluster-test

Conversation

@johannes94
Copy link
Copy Markdown
Contributor

@johannes94 johannes94 commented Jan 22, 2025

Description

This PR adds a GHA workflow to run the multicluster e2e tests against 2 infra clusters.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

Green CI on all existing + the added jobs is sufficient.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@johannes94 johannes94 marked this pull request as ready for review January 23, 2025 07:36
push:
branches:
- main
paths-ignore:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these specific paths?

Copy link
Copy Markdown
Contributor Author

@johannes94 johannes94 Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to run always because we're going to create 2 clusters for each run.

I selected specifically this paths because the migration logic consists of the API to reassign clusters (thus admin handler and dinosaur service) and the logic to cleanup/reprovision which lives in runtime and reconciler packages.

Thanks for commenting this made me realize that I forgot to change this to paths instead of paths-ignore.

user=$(echo "$creds" | cut -d':' -f1)
pw=$(echo "$creds" | cut -d':' -f2)
echo "RH_REGISTRY_PW=$pw" >> "$GITHUB_ENV"
echo "RH_REGISTRY_USER=$user" >> "$GITHUB_ENV"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very minor nit but please put the user over the pw to keep the order consistent

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, johannes94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 11, 2025

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants