Skip to content

ROX-28157: emailsender return 429 status on rate limit hit#2207

Merged
johannes94 merged 2 commits intomainfrom
jmalsam/ratelimit-error-fix
Feb 19, 2025
Merged

ROX-28157: emailsender return 429 status on rate limit hit#2207
johannes94 merged 2 commits intomainfrom
jmalsam/ratelimit-error-fix

Conversation

@johannes94
Copy link
Copy Markdown
Contributor

@johannes94 johannes94 commented Feb 18, 2025

Description

Adds some logic and tests to return 429 rate limited instead of 500 cannot send mail for rate limited requests against emailsender.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

CI and local test unit test execution.

Copy link
Copy Markdown
Member

@kurlov kurlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94
Copy link
Copy Markdown
Contributor Author

/retest

@johannes94 johannes94 merged commit d4d0dea into main Feb 19, 2025
16 checks passed
@johannes94 johannes94 deleted the jmalsam/ratelimit-error-fix branch February 19, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants