Skip to content

ROX-31828: Declare fleetshard-sync AWS role ARN as a helm value instead of an SSM parameter#2488

Merged
kovayur merged 2 commits intomainfrom
yury/ROX-31828-remove-fss-ssm
Nov 19, 2025
Merged

ROX-31828: Declare fleetshard-sync AWS role ARN as a helm value instead of an SSM parameter#2488
kovayur merged 2 commits intomainfrom
yury/ROX-31828-remove-fss-ssm

Conversation

@kovayur
Copy link
Contributor

@kovayur kovayur commented Nov 17, 2025

Description

To avoid AWS conflicts and streamline our AWS configuration, we need to make a fleetshard-sync IAM role per data plane cluster. To do this, we either need to change the ssm parameter or move it to helm values. In this PR, I did the latter.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur changed the title ROX-31828: Declare fleetshard-sync AWS role ARN as a helm value instead of SSM parameter ROX-31828: Declare fleetshard-sync AWS role ARN as a helm value instead of an SSM parameter Nov 17, 2025
@kovayur kovayur requested a review from johannes94 November 17, 2025 16:44
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Contributor Author

kovayur commented Nov 19, 2025

/retest

@openshift-ci openshift-ci bot removed the lgtm label Nov 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

New changes are detected. LGTM label has been removed.

@kovayur kovayur force-pushed the yury/ROX-31828-remove-fss-ssm branch from 4d35005 to 12d45ea Compare November 19, 2025 15:25
@kovayur kovayur merged commit 8b1e191 into main Nov 19, 2025
14 checks passed
@kovayur kovayur deleted the yury/ROX-31828-remove-fss-ssm branch November 19, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants