ROX-9409: removes PROBE_NAME and PROBE_VERSION #3
Merged
Stringy merged 3 commits intomauro/pull-falco-20220428from May 13, 2022
Merged
Conversation
Collaborator
Author
|
Just realised I forgot to remove all the other instances of |
5 tasks
Contributor
|
I'm seeing that most of the changes to rename Would it make sense to try and pull the latest changes of falco into our repo before making this change? Last time a tried there were a significant number of conflicts, but I'm up for it. |
Stringy
force-pushed
the
giles/ROX-9409-setting-probe-name-and-probe-version
branch
3 times, most recently
from
19c5481 to
f1a8ddb
Compare
Stringy
force-pushed
the
giles/ROX-9409-setting-probe-name-and-probe-version
branch
from
f1a8ddb to
dc9da45
Compare
…ME and DRIVER_VERSION used by userspace/libscap/CMakeLists.txt
Stringy
force-pushed
the
giles/ROX-9409-setting-probe-name-and-probe-version
branch
from
dc9da45 to
49bace8
Compare
Stringy
pushed a commit
that referenced
this pull request
Feb 26, 2026
glibc-2.42 added __inet_ntop_chk fortification, which started to fail: *** buffer overflow detected ***: terminated Program received signal SIGABRT, Aborted. 0x00007ffff629b0dc in __pthread_kill_implementation () from /lib64/libc.so.6 (gdb) bt #0 0x00007ffff629b0dc in __pthread_kill_implementation () from /lib64/libc.so.6 #1 0x00007ffff6242572 in raise () from /lib64/libc.so.6 #2 0x00007ffff6229f3b in abort () from /lib64/libc.so.6 #3 0x00007ffff622b148 in __libc_message_impl.cold () from /lib64/libc.so.6 #4 0x00007ffff6327337 in __fortify_fail () from /lib64/libc.so.6 #5 0x00007ffff6326c92 in __chk_fail () from /lib64/libc.so.6 #6 0x00007ffff6327a62 in __inet_ntop_chk () from /lib64/libc.so.6 #7 0x000055555569da3d in inet_ntop (__af=10, __src=0x555555ee0800, __dst=0x7fffffff4f90 "\260P\377\377\377\177", __dst_size=100) at /usr/include/bits/inet-fortified.h:36 #8 ipv6tuple_to_string[abi:cxx11](ipv6tuple*, bool) (tuple=0x555555ee0800, resolve=false) at /tmp/portage/dev-debug/sysdig-0.40.1/work/libs-0.20.0/userspace/libsinsp/utils.c Use INET6_ADDRSTRLEN as destination buffer size. Fixes: falcosecurity/libs#2573 Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In favour of DRIVER_NAME and DRIVER_VERSION used by userspace/libscap/CMakeLists.txt
This will not be upstreamed, since these configuration options exist on upstream already. This will be accompanied by a similar PR in the collector repo, to use these DRIVER_* variables as well.