Skip to content

Replace g_events_mask with consumer mask#7

Merged
Molter73 merged 1 commit intomasterfrom
mauro/unify-syscall-filtering
Mar 10, 2022
Merged

Replace g_events_mask with consumer mask#7
Molter73 merged 1 commit intomasterfrom
mauro/unify-syscall-filtering

Conversation

@Molter73
Copy link
Contributor

This PR fixes compilation for the collector module by removing the global events mask and using the mask embedded in the consumers.

@Molter73 Molter73 requested a review from Stringy March 10, 2022 10:29
@Molter73 Molter73 self-assigned this Mar 10, 2022
@Molter73 Molter73 changed the base branch from mauro/pull-falco-changes-20220309 to master March 10, 2022 15:24
@Molter73 Molter73 force-pushed the mauro/unify-syscall-filtering branch from 9315656 to 0a28425 Compare March 10, 2022 15:25
@Molter73 Molter73 merged commit b1b7615 into master Mar 10, 2022
Stringy pushed a commit that referenced this pull request Jan 20, 2023
Stringy pushed a commit that referenced this pull request Apr 19, 2023
Stringy pushed a commit that referenced this pull request Apr 27, 2023
Stringy pushed a commit that referenced this pull request Apr 27, 2023
Stringy pushed a commit that referenced this pull request Feb 26, 2026
glibc-2.42 added __inet_ntop_chk fortification, which started to fail:

  *** buffer overflow detected ***: terminated
  Program received signal SIGABRT, Aborted.
  0x00007ffff629b0dc in __pthread_kill_implementation () from /lib64/libc.so.6
  (gdb) bt
  #0  0x00007ffff629b0dc in __pthread_kill_implementation () from /lib64/libc.so.6
  #1  0x00007ffff6242572 in raise () from /lib64/libc.so.6
  #2  0x00007ffff6229f3b in abort () from /lib64/libc.so.6
  #3  0x00007ffff622b148 in __libc_message_impl.cold () from /lib64/libc.so.6
  #4  0x00007ffff6327337 in __fortify_fail () from /lib64/libc.so.6
  #5  0x00007ffff6326c92 in __chk_fail () from /lib64/libc.so.6
  #6  0x00007ffff6327a62 in __inet_ntop_chk () from /lib64/libc.so.6
  #7  0x000055555569da3d in inet_ntop (__af=10, __src=0x555555ee0800, __dst=0x7fffffff4f90 "\260P\377\377\377\177", __dst_size=100) at /usr/include/bits/inet-fortified.h:36
  #8  ipv6tuple_to_string[abi:cxx11](ipv6tuple*, bool) (tuple=0x555555ee0800, resolve=false) at /tmp/portage/dev-debug/sysdig-0.40.1/work/libs-0.20.0/userspace/libsinsp/utils.c

Use INET6_ADDRSTRLEN as destination buffer size.

Fixes: falcosecurity/libs#2573
Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants