temp fix for argo workflow validation error (restore 0.0.7 DAG)#320
Merged
Conversation
added 5 commits
January 20, 2021 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Problem
Release 0.0.8 introduced a functional regression from RS-125/RS-128 for GKE cluster creation.
Release 0.0.8 introduced new AKS support but also included a functional regression from my PR which broke the workflow.
OpenShift and Kops are likely broken as well.
Error reported from Argo Workflow engine
Root Cause
The "onExit" handler I added to Argo workflow definitions worked for "demo" flavor but fails to validate at runtime for other workflows. This PR reverts just the workflows onExit handlers to preserve fixes/enhancements through 0.0.8 but un-break the aberrant workflow handling for cluster flavors other than "demo".
Testing the fix-forward