Skip to content

temp fix for argo workflow validation error (restore 0.0.7 DAG)#320

Merged
sbostk merged 6 commits into
masterfrom
shane/infra-server-workflow-fix
Jan 21, 2021
Merged

temp fix for argo workflow validation error (restore 0.0.7 DAG)#320
sbostk merged 6 commits into
masterfrom
shane/infra-server-workflow-fix

Conversation

@sbostk
Copy link
Copy Markdown
Contributor

@sbostk sbostk commented Jan 20, 2021

Fixes

  • Restore 0.0.7 workflow DAGs (remove onExit handler and restore "stop" step)
  • Add argo workflow lint target to Makefile. Ideally would be run by default against all workflows prior to image build but circleci executor does not have argo cli client installed.

Problem

Release 0.0.8 introduced a functional regression from RS-125/RS-128 for GKE cluster creation.
Release 0.0.8 introduced new AKS support but also included a functional regression from my PR which broke the workflow.
OpenShift and Kops are likely broken as well.

Error reported from Argo Workflow engine

"message": "invalid spec: templates.stop.steps failed to resolve {{steps.create.outputs.parameters.cluster_name}}",

Root Cause

The "onExit" handler I added to Argo workflow definitions worked for "demo" flavor but fails to validate at runtime for other workflows. This PR reverts just the workflows onExit handlers to preserve fixes/enhancements through 0.0.8 but un-break the aberrant workflow handling for cluster flavors other than "demo".

Testing the fix-forward

  • demo cluster created
  • gke cluster created
  • eks cluster created
  • aks cluster created (cluster create failures were just resource limit exceedance in Azure)
  • calendar scheduled demo created

@sbostk sbostk marked this pull request as ready for review January 21, 2021 02:31
Copy link
Copy Markdown
Contributor

@gavin-stackrox gavin-stackrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbostk sbostk merged commit 829afcf into master Jan 21, 2021
@sbostk sbostk deleted the shane/infra-server-workflow-fix branch January 21, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants