temp fix for argo workflow validation error (restore 0.0.7 DAG)

Makefile

@@ -268,3 +268,7 @@ deploy-production: push install-production
 gotags:
 	@gotags -R . > tags
 	@echo "GoTags written to $(PWD)/tags"
+
+.PHONY: argo-workflow-lint
+argo-workflow-lint:
+	@argo lint ./chart/infra-server/static/workflow*.yaml

TROUBLESHOOTING.md

@@ -78,8 +78,6 @@ STEP                    PODNAME                DURATION  ARTIFACTS  MESSAGE
 
 To get logs from a step, run:
 
-(it's just a pod, so `kubectl logs ...` would also work)
-
 ```
 argo logs demo-mxgf9-3875809567 | head -n 20
 [PASS] /tmp/google-credentials.json (GCP service account credential file)
@@ -91,6 +89,15 @@ argo logs demo-mxgf9-3875809567 | head -n 20
 [PASS] DOCKER_IO_USERNAME (username for Docker Hub)
 ```
 
+The workflow steps are just pod executions, so `kubectl logs ...` also works:
+```
+MY_CLUSTER_NAME=demo-mxgf9
+WORKFLOW_STEP_POD_ID=$(argo get oc-init-bundle-test -o json | jq -r '.status.nodes[] | select(.type=="Pod") | select(.displayName=="create") | .id')
+kubectl logs $WORKFLOW_STEP_POD_ID -c 'main'
+# Retrieving logs via argo cli obviates the need to specify the container
+argo logs $MY_CLUSTER_NAME $WORKFLOW_STEP_POD_ID --follow
+```
+
 If a step is stuck in a pending state (e.x. a referenced secret doesn't exist),
 `argo get` should show that information. Otherwise `kubectl describe po ...` can
 be used to see exact reasons.
@@ -130,3 +137,10 @@ eks-2h8gb   Running (Suspended)   24m   24m        0
 # and can be resumed to test steps after that i.e. delete
 $ argo resume eks-2h8gb
 ```
+
+## View the Argo Workflows web interface
+
+```
+kubectl -n argo port-forward deployment/argo-server 2746:2746
+open http://localhost:2746/workflows/
+```

chart/infra-server/static/workflow-aks.yaml

@@ -4,7 +4,6 @@ metadata:
   generateName: aks-
 spec:
   entrypoint: start
-  onExit: stop
   arguments:
     parameters:
       - name: name
@@ -28,8 +27,6 @@ spec:
         - - name: wait
             template: wait
 
-    - name: stop
-      steps:
         - - name: destroy
             template: destroy
 

chart/infra-server/static/workflow-eks.yaml

@@ -4,7 +4,6 @@ metadata:
   generateName: eks-
 spec:
   entrypoint: start
-  onExit: stop
   arguments:
     parameters:
       - name: name
@@ -26,8 +25,6 @@ spec:
         - - name: wait
             template: wait
 
-    - name: stop
-      steps:
         - - name: destroy
             template: destroy
 

chart/infra-server/static/workflow-gke-default.yaml

@@ -4,7 +4,6 @@ metadata:
   generateName: gke-default-
 spec:
   entrypoint: start
-  onExit: stop
   arguments:
     parameters:
       - name: name
@@ -29,9 +28,6 @@ spec:
             template: create
         - - name: wait
             template: wait
-
-    - name: stop
-      steps:
         - - name: destroy
             template: destroy
             arguments:

chart/infra-server/static/workflow-kops.yaml

@@ -4,7 +4,6 @@ metadata:
   generateName: kops-
 spec:
   entrypoint: start
-  onExit: stop
   arguments:
     parameters:
       - name: name
@@ -42,8 +41,6 @@ spec:
         - - name: wait
             template: wait
 
-    - name: stop
-      steps:
         - - name: destroy
             template: destroy
 

chart/infra-server/static/workflow-openshift-lite.yaml

@@ -4,7 +4,6 @@ metadata:
   generateName: openshift-lite-
 spec:
   entrypoint: start
-  onExit: stop
   arguments:
     parameters:
       - name: name
@@ -25,9 +24,6 @@ spec:
 
         - - name: wait
             template: wait
-
-    - name: stop
-      steps:
         - - name: destroy
             template: destroy
             arguments:

chart/infra-server/static/workflow-openshift-multi.yaml

@@ -4,7 +4,6 @@ metadata:
   generateName: openshift-multi-
 spec:
   entrypoint: start
-  onExit: stop
   arguments:
     parameters:
       - name: name
@@ -28,9 +27,6 @@ spec:
 
         - - name: wait
             template: wait
-
-    - name: stop
-      steps:
         - - name: destroy
             template: destroy
             arguments: