Periodically delete old workflows#47
Merged
Merged
Conversation
al13n
approved these changes
Apr 25, 2020
| // | ||
| // E.g. a workflow must have finished more than 24 hours ago before it is | ||
| // considered for deletion. | ||
| const workflowMaxAgeGracePeriod = 24 * time.Hour |
Contributor
There was a problem hiding this comment.
Just for context, what makes this grace period useful? Would it be helpful to comment it here?
Contributor
Author
There was a problem hiding this comment.
Ah. I expound on it here (https://github.com/stackrox/infra/pull/47/files#diff-c18c4c95a88e0fc7894470522a609f99R639) but I'll include that information in the comment here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.