Skip to content

ROX-34425: resolve file access violations#20218

Merged
Stringy merged 2 commits into
masterfrom
giles/fix-splunk-cim-file-access
Apr 27, 2026
Merged

ROX-34425: resolve file access violations#20218
Stringy merged 2 commits into
masterfrom
giles/fix-splunk-cim-file-access

Conversation

@Stringy

@Stringy Stringy commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Description

Further strictness for splunk TA tests, and ensure file access tests resolve violations to avoid contamination of other test suites.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI should be enough (with ci-all-qa-tests label)

@Stringy Stringy requested a review from janisz as a code owner April 24, 2026 15:58
@Stringy Stringy added ci-all-qa-tests Tells CI to run all API tests (not just BAT). auto-retest PRs with this label will be automatically retested if prow checks fails labels Apr 24, 2026
@Stringy

Stringy commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

/test ocp-4-21-qa-e2e-tests

@Stringy

Stringy commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest-times 10 ocp-4-21-qa-e2e-tests

@github-actions

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 805cde4. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-787-g805cde4a63

Comment thread qa-tests-backend/src/test/groovy/IntegrationsSplunkViolationsTest.groovy Outdated
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.79%. Comparing base (121ffc3) to head (f7afb7f).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20218   +/-   ##
=======================================
  Coverage   49.79%   49.79%           
=======================================
  Files        2770     2770           
  Lines      210212   210212           
=======================================
+ Hits       104667   104674    +7     
+ Misses      97823    97817    -6     
+ Partials     7722     7721    -1     
Flag Coverage Δ
go-unit-tests 49.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

9 similar comments
@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@rhacs-bot

Copy link
Copy Markdown
Contributor

/test ocp-4-21-qa-e2e-tests

@Stringy

Stringy commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

I've run ocp-4-21-qa-e2e-tests ten times, and it has been successful every time: https://prow.ci.openshift.org/pr-history/?org=stackrox&repo=stackrox&pr=20218

with the ci-all-qa-tests label it runs with the splunk TA tests, and we can see that it also runs the file activity tests; the combination of which was causing this instability.

I'll make @janisz's suggested change and wait for this to pass once again, then merge.

@Stringy

Stringy commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

/test ocp-4-21-qa-e2e-tests

@Stringy Stringy merged commit 805cde4 into master Apr 27, 2026
97 checks passed
@Stringy Stringy deleted the giles/fix-splunk-cim-file-access branch April 27, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-retest PRs with this label will be automatically retested if prow checks fails ci-all-qa-tests Tells CI to run all API tests (not just BAT).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants