Skip to content

ROX-34488: add e2e tests for referrer-based signature verification#21910

Draft
stehessel wants to merge 1 commit into
ROX-34488/3-bundle-verificationfrom
ROX-34488/4-e2e-tests
Draft

ROX-34488: add e2e tests for referrer-based signature verification#21910
stehessel wants to merge 1 commit into
ROX-34488/3-bundle-verificationfrom
ROX-34488/4-e2e-tests

Conversation

@stehessel

@stehessel stehessel commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Add two test images (public-key and keyless sigstore bundle) with corresponding deployments, integrations, and test matrix entries. Includes a runbook for recreating the signed test images.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

E2e test matrix in ImageSignatureVerificationTest.groovy extended with referrer-based deployments covering both public-key and keyless sigstore bundle verification. CHANGELOG updated.

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 0091490. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-582-g0091490a28

@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from 4abbdcc to adc131b Compare July 23, 2026 14:32
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch 2 times, most recently from ac1bfaf to d42befb Compare July 23, 2026 14:50
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from adc131b to 9971f0f Compare July 23, 2026 14:50
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from d42befb to 58d607f Compare July 23, 2026 15:56
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from 9971f0f to 3b0013a Compare July 23, 2026 15:56
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from 58d607f to 382cde0 Compare July 23, 2026 16:12
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from 3b0013a to 96e3a7b Compare July 23, 2026 16:12
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from 382cde0 to 031cfac Compare July 23, 2026 16:50
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from 96e3a7b to de42a40 Compare July 23, 2026 16:50
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from 031cfac to 2cdf8d1 Compare July 23, 2026 17:10
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from de42a40 to 46bd1e5 Compare July 23, 2026 17:11
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch 2 times, most recently from 95b7473 to 81550d2 Compare July 23, 2026 17:19
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from 46bd1e5 to b7c79ae Compare July 23, 2026 17:21
@stehessel

Copy link
Copy Markdown
Collaborator Author

/test ocp-4-22-qa-e2e-tests gke-qa-e2e-tests ocp-4-21-qa-e2e-tests

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

@stehessel: No presubmit jobs available for stackrox/stackrox@ROX-34488/3-bundle-verification

Details

In response to this:

/test ocp-4-22-qa-e2e-tests gke-qa-e2e-tests ocp-4-21-qa-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.36%. Comparing base (a1f1f21) to head (83b8c74).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           ROX-34488/3-bundle-verification   #21910      +/-   ##
===================================================================
- Coverage                            51.36%   51.36%   -0.01%     
===================================================================
  Files                                 2858     2858              
  Lines                               178986   178986              
===================================================================
- Hits                                 91939    91930       -9     
- Misses                               78989    78995       +6     
- Partials                              8058     8061       +3     
Flag Coverage Δ
go-unit-tests 51.36% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from 81550d2 to 0ffc330 Compare July 23, 2026 20:31
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from b7c79ae to 35dc2fd Compare July 23, 2026 20:31
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from 0ffc330 to b292e59 Compare July 24, 2026 08:37
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from 35dc2fd to 9558011 Compare July 24, 2026 08:37
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from b292e59 to e2cc476 Compare July 24, 2026 08:56
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch 2 times, most recently from 114809d to e8c12bd Compare July 24, 2026 09:41
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from e2cc476 to a1f1f21 Compare July 24, 2026 10:00
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from e8c12bd to 83b8c74 Compare July 24, 2026 10:00
@stehessel
stehessel force-pushed the ROX-34488/3-bundle-verification branch from a1f1f21 to e6fd2f3 Compare July 24, 2026 13:45
Add two test images (public-key and keyless sigstore bundle) with
corresponding deployments, integrations, and test matrix entries.
Includes a runbook for recreating the signed test images.

Partially generated by AI.
@stehessel
stehessel force-pushed the ROX-34488/4-e2e-tests branch from 83b8c74 to 0091490 Compare July 24, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant