…#306) * feat(databricks): remaining Microsoft.Databricks ARM resources (#209) Finish the Microsoft.Databricks ARM control-plane surface beyond workspaces (built in #164), all reachable over the real armdatabricks SDK: - Access Connectors (accessConnectors): createOrUpdate, get, update, delete, list by resource group, list by subscription. System-assigned identities get synthesized principal/tenant IDs. - Private Endpoint Connections (workspaces/{w}/privateEndpointConnections): create, get, list, delete. - Private Link Resources (workspaces/{w}/privateLinkResources): get, list (synthesized databricks_ui_api / browser_authentication group set). - VNet Peering (workspaces/{w}/virtualNetworkPeerings): createOrUpdate, get, list, delete. - Outbound Network Dependencies Endpoints (workspaces/{w}/outboundNetworkDependenciesEndpoints): list (bare-array response, matching the SDK deserializer). - Operations (/providers/Microsoft.Databricks/operations): list — served via a subscription-less path special-case since azurearm.ParsePath requires a /subscriptions prefix. Built across all four layers: driver interface + types, in-memory provider Mock (memstore-backed, copy-on-write), portable service with the do() cross-cutting pipeline, and the SDK-compat ARM HTTP handler (routing extended for the new top-level type, workspace sub-resources, and the operations path). Modeled store-and-echo: the ARM resources round-trip faithfully over the SDK, but the underlying Azure networking side effects (real private endpoints, live VNet peering, outbound reachability) are not simulated — see docs/services.md. Tests: 21 SDK round-trip tests driving the real armdatabricks clients against an httptest server, plus 9 provider-level unit tests, covering happy paths and edge cases (not found, missing parent workspace, empty list, PATCH semantics, rejected PEC status, the no-subscription operations path). * fix(databricks): address review — case-insensitive routing, idempotent delete Addresses the re-review of #306: - Case-insensitive ARM routing (Medium): the handler matched the provider namespace and resource-type/sub-resource segments with ==, but ARM treats them case-insensitively (and the same file's isOperationsPath / the shared parseResourceGroup already use EqualFold). A lowercased path such as .../providers/microsoft.databricks/accessconnectors would 404. Now uses strings.EqualFold throughout Matches/ServeHTTP/serveWorkspaceChild. - Idempotent DELETE (Medium): DeleteAccessConnector / DeletePrivateEndpoint / DeleteVNetPeering returned 404 on a missing resource and 200 on success. Real ARM DELETE is idempotent — now 204 on success and 204 on a NotFound (matching the resourcegroups handler precedent), so teardown retries / delete-then-delete succeed. Pre-existing workspace delete (#164) left untouched. - Access-connector identity realism (Low): system-assigned principalId is now keyed on (resourceGroup, name) so same-named connectors in different RGs get distinct principals; tenantId is a single fixed emulator-wide directory GUID rather than a per-name synthesized value. - Docs (Low): §21 op-count total and the coverage-summary row bumped 52 -> 70 (this PR adds 18 driver operations). Tests: new SDK round-trip tests for case-insensitive routing (raw HTTP, since the SDK emits canonical casing), idempotent delete-of-missing across the three resources, and the PATCH-identity=None transition; all via the real armdatabricks clients. go build/vet/test/-race and golangci-lint (0 issues) green. * chore: re-trigger CI The prior CI run failed only on an unrelated, pre-existing flaky test: server/aws/bedrock TestSDKConverseStream ('use of closed network connection') — a load-sensitive httptest streaming-connection race from #298, not touched by this PR. All other checks pass and the test is green locally (30/30, incl. -race). No admin rights to re-run the job, so this empty commit re-triggers the pull_request workflow. * fix(bedrock): drain request body before streaming converse-stream response CI's `go test -race` intermittently failed TestSDKConverseStream with "use of closed network connection" — a pre-existing, load-sensitive flake (from #298) surfaced by the race detector's slowdown on the 2-core runner. Root cause: converseStream decodes the request via json.Decoder, which stops at the end of the JSON value and leaves the body unread (e.g. a trailing newline). With an unread request body, net/http cannot finish the connection gracefully once the chunked event-stream response has started, so it tears the TCP connection down when the handler returns — racing the SDK client's in-flight read of the stream. invokeModelStream already reads the whole body via io.ReadAll, which is why only converse-stream flaked. Fix: io.Copy(io.Discard, r.Body) after decoding, before switching to the streamed response, so the connection is finished cleanly and the client reads a normal end-of-stream instead of a reset. Full bedrock suite green under -race (20x on the streaming tests); build, vet, go test ./..., and golangci-lint clean.

Uh oh!

feat: Azure Databricks SDK-compat handler #164

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions