Skip to content

update #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NitinKumar004 merged 2 commits into from
Mar 1, 2026
Merged

update #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c4503
enhance metrics part for resources
NitinKumar004 Mar 1, 2026
9a3449e
Merge pull request #3 from NitinKumar004/fix/extend_metrics
NitinKumar004 Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions cloudemu_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,3 +1133,91 @@ func TestAlarmTriggeredByAutoMetrics(t *testing.T) {
t.Errorf("expected ALARM after auto-metrics (CPU=25 > 0), got %s", alarms[0].State)
}
}

func TestLifecycleStopEmitsZeroMetrics(t *testing.T) {
ctx := context.Background()
clock := config.NewFakeClock(time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC))
p := NewAWS(config.WithClock(clock))

// Create alarm: CPU < 1 (LessThanThreshold)
if err := p.CloudWatch.CreateAlarm(ctx, mondriver.AlarmConfig{
Name: "low-cpu", Namespace: "AWS/EC2", MetricName: "CPUUtilization",
ComparisonOperator: "LessThanThreshold", Threshold: 1,
Period: 300, EvaluationPeriods: 1, Stat: "Average",
}); err != nil {
t.Fatal(err)
}

// RunInstances → CPU=25 → alarm stays OK (25 is not < 1)
instances, err := p.EC2.RunInstances(ctx, computedriver.InstanceConfig{
ImageID: "ami-test", InstanceType: "t2.micro",
}, 1)
if err != nil {
t.Fatal(err)
}
id := instances[0].ID

alarms, _ := p.CloudWatch.DescribeAlarms(ctx, []string{"low-cpu"})
if alarms[0].State != "OK" {
t.Errorf("expected OK after RunInstances (CPU=25, not < 1), got %s", alarms[0].State)
}

// Advance clock past evaluation window so old datapoints fall out
clock.Advance(11 * time.Minute)

// StopInstances → CPU=0 → alarm fires ALARM (0 < 1)
if err := p.EC2.StopInstances(ctx, []string{id}); err != nil {
t.Fatal(err)
}

alarms, _ = p.CloudWatch.DescribeAlarms(ctx, []string{"low-cpu"})
if alarms[0].State != "ALARM" {
t.Errorf("expected ALARM after StopInstances (CPU=0 < 1), got %s", alarms[0].State)
}
}

func TestLifecycleStartEmitsRunningMetrics(t *testing.T) {
ctx := context.Background()
clock := config.NewFakeClock(time.Date(2024, 1, 1, 12, 0, 0, 0, time.UTC))
p := NewAWS(config.WithClock(clock))

// Create alarm: CPU > 0
if err := p.CloudWatch.CreateAlarm(ctx, mondriver.AlarmConfig{
Name: "any-cpu-start", Namespace: "AWS/EC2", MetricName: "CPUUtilization",
ComparisonOperator: "GreaterThanThreshold", Threshold: 0,
Period: 300, EvaluationPeriods: 1, Stat: "Average",
}); err != nil {
t.Fatal(err)
}

// RunInstances → stop → advance clock → start
instances, err := p.EC2.RunInstances(ctx, computedriver.InstanceConfig{
ImageID: "ami-test", InstanceType: "t2.micro",
}, 1)
if err != nil {
t.Fatal(err)
}
id := instances[0].ID

if err := p.EC2.StopInstances(ctx, []string{id}); err != nil {
t.Fatal(err)
}

// Advance clock past evaluation window so old datapoints fall out
clock.Advance(11 * time.Minute)

// Stop emitted zeros, so after window expiry only zeros remain → alarm should be OK
// But we need fresh data, so push a zero to re-evaluate
// Actually, StopInstances already pushed zeros at t0+0. After advancing 11min,
// those zeros are outside the 5min window. We need StartInstances to push new running data.

// StartInstances → CPU=25 → alarm fires (25 > 0)
if err := p.EC2.StartInstances(ctx, []string{id}); err != nil {
t.Fatal(err)
}

alarms, _ := p.CloudWatch.DescribeAlarms(ctx, []string{"any-cpu-start"})
if alarms[0].State != "ALARM" {
t.Errorf("expected ALARM after StartInstances (CPU=25 > 0), got %s", alarms[0].State)
}
}
37 changes: 33 additions & 4 deletions providers/aws/ec2/ec2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ import (

var _ driver.Compute = (*Mock)(nil)

var (
runningMetricValues = []float64{25.0, 1024.0, 512.0, 100.0, 50.0}
zeroMetricValues = []float64{0.0, 0.0, 0.0, 0.0, 0.0}
)

type instanceData struct {
ID string
ImageID string
Expand Down Expand Up @@ -73,6 +78,26 @@ func (m *Mock) emitInstanceMetrics(ctx context.Context, instanceID, launchTime s
_ = m.monitoring.PutMetricData(ctx, data)
}

func (m *Mock) emitLifecycleMetrics(ctx context.Context, instanceID string, values []float64) {
if m.monitoring == nil {
return
}
metrics := []string{"CPUUtilization", "NetworkIn", "NetworkOut", "DiskReadOps", "DiskWriteOps"}
now := m.opts.Clock.Now()
data := make([]mondriver.MetricDatum, len(metrics))
for i, metricName := range metrics {
data[i] = mondriver.MetricDatum{
Namespace: "AWS/EC2",
MetricName: metricName,
Value: values[i],
Unit: "None",
Dimensions: map[string]string{"InstanceId": instanceID},
Timestamp: now,
}
}
_ = m.monitoring.PutMetricData(ctx, data)
}

// New creates a new EC2 mock.
func New(opts *config.Options) *Mock {
return &Mock{
Expand Down Expand Up @@ -130,7 +155,7 @@ func (m *Mock) RunInstances(ctx context.Context, cfg driver.InstanceConfig, coun
return results, nil
}

func (m *Mock) StartInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) StartInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -142,11 +167,12 @@ func (m *Mock) StartInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StatePending
_ = m.sm.Transition(id, compute.StateRunning)
inst.State = compute.StateRunning
m.emitLifecycleMetrics(ctx, id, runningMetricValues)
}
return nil
}

func (m *Mock) StopInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) StopInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -158,11 +184,12 @@ func (m *Mock) StopInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StateStopping
_ = m.sm.Transition(id, compute.StateStopped)
inst.State = compute.StateStopped
m.emitLifecycleMetrics(ctx, id, zeroMetricValues)
}
return nil
}

func (m *Mock) RebootInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) RebootInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -174,11 +201,12 @@ func (m *Mock) RebootInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StateRestarting
_ = m.sm.Transition(id, compute.StateRunning)
inst.State = compute.StateRunning
m.emitLifecycleMetrics(ctx, id, runningMetricValues)
}
return nil
}

func (m *Mock) TerminateInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) TerminateInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -190,6 +218,7 @@ func (m *Mock) TerminateInstances(_ context.Context, instanceIDs []string) error
inst.State = compute.StateShuttingDown
_ = m.sm.Transition(id, compute.StateTerminated)
inst.State = compute.StateTerminated
m.emitLifecycleMetrics(ctx, id, zeroMetricValues)
}
return nil
}
Expand Down
37 changes: 33 additions & 4 deletions providers/azure/virtualmachines/vm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ import (
// Compile-time check that Mock implements driver.Compute.
var _ driver.Compute = (*Mock)(nil)

var (
runningMetricValues = []float64{25.0, 1024.0, 512.0, 100.0, 50.0}
zeroMetricValues = []float64{0.0, 0.0, 0.0, 0.0, 0.0}
)

type instanceData struct {
ID string
ImageID string
Expand Down Expand Up @@ -75,6 +80,26 @@ func (m *Mock) emitInstanceMetrics(ctx context.Context, instanceID, launchTime s
_ = m.monitoring.PutMetricData(ctx, data)
}

func (m *Mock) emitLifecycleMetrics(ctx context.Context, instanceID string, values []float64) {
if m.monitoring == nil {
return
}
metrics := []string{"Percentage CPU", "Network In Total", "Network Out Total", "Disk Read Operations/Sec", "Disk Write Operations/Sec"}
now := m.opts.Clock.Now()
data := make([]mondriver.MetricDatum, len(metrics))
for i, metricName := range metrics {
data[i] = mondriver.MetricDatum{
Namespace: "Microsoft.Compute/virtualMachines",
MetricName: metricName,
Value: values[i],
Unit: "None",
Dimensions: map[string]string{"resourceId": instanceID},
Timestamp: now,
}
}
_ = m.monitoring.PutMetricData(ctx, data)
}

// New creates a new Azure Virtual Machines mock.
func New(opts *config.Options) *Mock {
return &Mock{
Expand Down Expand Up @@ -134,7 +159,7 @@ func (m *Mock) RunInstances(ctx context.Context, cfg driver.InstanceConfig, coun
}

// StartInstances starts the specified stopped virtual machine instances.
func (m *Mock) StartInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) StartInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -146,12 +171,13 @@ func (m *Mock) StartInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StatePending
_ = m.sm.Transition(id, compute.StateRunning)
inst.State = compute.StateRunning
m.emitLifecycleMetrics(ctx, id, runningMetricValues)
}
return nil
}

// StopInstances stops the specified running virtual machine instances.
func (m *Mock) StopInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) StopInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -163,12 +189,13 @@ func (m *Mock) StopInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StateStopping
_ = m.sm.Transition(id, compute.StateStopped)
inst.State = compute.StateStopped
m.emitLifecycleMetrics(ctx, id, zeroMetricValues)
}
return nil
}

// RebootInstances reboots the specified running virtual machine instances.
func (m *Mock) RebootInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) RebootInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -180,12 +207,13 @@ func (m *Mock) RebootInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StateRestarting
_ = m.sm.Transition(id, compute.StateRunning)
inst.State = compute.StateRunning
m.emitLifecycleMetrics(ctx, id, runningMetricValues)
}
return nil
}

// TerminateInstances terminates the specified virtual machine instances.
func (m *Mock) TerminateInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) TerminateInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -197,6 +225,7 @@ func (m *Mock) TerminateInstances(_ context.Context, instanceIDs []string) error
inst.State = compute.StateShuttingDown
_ = m.sm.Transition(id, compute.StateTerminated)
inst.State = compute.StateTerminated
m.emitLifecycleMetrics(ctx, id, zeroMetricValues)
}
return nil
}
Expand Down
37 changes: 33 additions & 4 deletions providers/gcp/gce/gce.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ import (
// Compile-time check that Mock implements driver.Compute.
var _ driver.Compute = (*Mock)(nil)

var (
runningMetricValues = []float64{0.25, 1024.0, 512.0, 100.0, 50.0}
zeroMetricValues = []float64{0.0, 0.0, 0.0, 0.0, 0.0}
)

type instanceData struct {
ID string
ImageID string
Expand Down Expand Up @@ -75,6 +80,26 @@ func (m *Mock) emitInstanceMetrics(ctx context.Context, instanceID, launchTime s
_ = m.monitoring.PutMetricData(ctx, data)
}

func (m *Mock) emitLifecycleMetrics(ctx context.Context, instanceID string, values []float64) {
if m.monitoring == nil {
return
}
metrics := []string{"instance/cpu/utilization", "instance/network/received_bytes_count", "instance/network/sent_bytes_count", "instance/disk/read_ops_count", "instance/disk/write_ops_count"}
now := m.opts.Clock.Now()
data := make([]mondriver.MetricDatum, len(metrics))
for i, metricName := range metrics {
data[i] = mondriver.MetricDatum{
Namespace: "compute.googleapis.com",
MetricName: metricName,
Value: values[i],
Unit: "None",
Dimensions: map[string]string{"instance_id": instanceID},
Timestamp: now,
}
}
_ = m.monitoring.PutMetricData(ctx, data)
}

// New creates a new GCE mock.
func New(opts *config.Options) *Mock {
return &Mock{
Expand Down Expand Up @@ -132,7 +157,7 @@ func (m *Mock) RunInstances(ctx context.Context, cfg driver.InstanceConfig, coun
return results, nil
}

func (m *Mock) StartInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) StartInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -144,11 +169,12 @@ func (m *Mock) StartInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StatePending
_ = m.sm.Transition(id, compute.StateRunning)
inst.State = compute.StateRunning
m.emitLifecycleMetrics(ctx, id, runningMetricValues)
}
return nil
}

func (m *Mock) StopInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) StopInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -160,11 +186,12 @@ func (m *Mock) StopInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StateStopping
_ = m.sm.Transition(id, compute.StateStopped)
inst.State = compute.StateStopped
m.emitLifecycleMetrics(ctx, id, zeroMetricValues)
}
return nil
}

func (m *Mock) RebootInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) RebootInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -176,11 +203,12 @@ func (m *Mock) RebootInstances(_ context.Context, instanceIDs []string) error {
inst.State = compute.StateRestarting
_ = m.sm.Transition(id, compute.StateRunning)
inst.State = compute.StateRunning
m.emitLifecycleMetrics(ctx, id, runningMetricValues)
}
return nil
}

func (m *Mock) TerminateInstances(_ context.Context, instanceIDs []string) error {
func (m *Mock) TerminateInstances(ctx context.Context, instanceIDs []string) error {
for _, id := range instanceIDs {
inst, ok := m.instances.Get(id)
if !ok {
Expand All @@ -192,6 +220,7 @@ func (m *Mock) TerminateInstances(_ context.Context, instanceIDs []string) error
inst.State = compute.StateShuttingDown
_ = m.sm.Transition(id, compute.StateTerminated)
inst.State = compute.StateTerminated
m.emitLifecycleMetrics(ctx, id, zeroMetricValues)
}
return nil
}
Expand Down