Add TTL management and atomic counters to cache service - #67
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expire,GetTTL,Persist,Incr,IncrBy,Decr,DecrByIncr/Decron non-existent keys start from 0 (Redis behavior)Incr/Decrpreserve existing TTL on the keyGetTTLreturns -1 for keys with no TTL (Redis behavior)Closes #64
Test plan
Unit tests (per provider - 8-12 tests each)
TestExpire— set TTL on existing key, verify via GetTTL, verify expiryTestExpireKeyNotFound— returns error for missing keyTestPersist— remove TTL, verify key survives past original expiryTestPersistKeyNotFound— returns error for missing keyTestIncr— increment from 0, increment againTestIncrBy— increment by arbitrary deltaTestDecr— decrement existing valueTestDecrBy— decrement by arbitrary deltaTestIncrNonInteger— returns error for non-integer valuesTestIncrPreservesTTL— TTL preserved after incrementTestIncrCacheNotFound— returns error for missing cache (AWS)Integration tests (cloudemu_test.go)
TestCacheExpireAndPersistAWS/Azure/GCPTestCacheIncrDecrAWS/Azure/GCPVerification
golangci-lint run --timeout=9m ./...)go test ./...)