Live throttle control on the run console - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A live throttle slider on the run console. You can change a running operation's rate (rows/sec) at any time without stopping it — drag it down when production gets busy, drag it up when it's quiet.
0means unthrottled.Changes
PATCH /runs/{id}now accepts{"action":"speed","rate":N}. It adjusts the running runner's token bucket immediately (solo mode) and persists the new rate on the task, so it survives a reload. Arun.speedentry is written to the audit trail.?theme=query param (used to capture the dark-mode screenshot below).How to test
make up && make run, build the dashboard (cd web && npm run build), openhttp://localhost:8000/app.run.speedevent.Screenshots
Captured with headless Chrome.
Run console — throttle slider (light)
Run console — throttle slider (dark)
Tasks — run history + open active run
Notes