chart: fix reloader-namespaceSelector helper comment - #1204
Merged
msafwankarim merged 1 commit intoAug 10, 2026
Conversation
The helper only emits namespaceSelector when watchGlobally is true (matches values.yaml and the chart README). The old comment said the opposite and made the condition look inverted. Fixes stakater#1188 Signed-off-by: Dean Chen <862469039@qq.com>
msafwankarim
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper comment said it ran when not watching globally, but the
if(and the chart README / values notes) only wire--namespace-selectorwhenwatchGloballyis true.Left the condition alone; just aligned the comment so it stops looking like a logic bug.
Fixes #1188