fix: formatting issues, add txn passing instructions to semi-autonomous flow#5
Merged
Philippoes merged 5 commits intomainfrom Apr 3, 2026
Merged
fix: formatting issues, add txn passing instructions to semi-autonomous flow#5Philippoes merged 5 commits intomainfrom
Philippoes merged 5 commits intomainfrom
Conversation
📝 WalkthroughWalkthroughDocumentation-only updates across the yield-agentkit-privy skill: MCP name changed to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/architecture.md`:
- Line 37: Update the privy-wallets.md documentation so the ethereum chain_type
example explicitly lists BNB Chain (and optionally Avalanche) alongside the
other EVM chains; locate the ethereum entry in the privy-wallets.md table (the
chain_type column / "ethereum" row) and expand its example text from "All EVM
chains — Ethereum, Base, Arbitrum, Optimism, Polygon, etc." to include "BNB
Chain" (and "Avalanche" if desired) to match references in
privy-transactions.md, privy-policies.md, and the README.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2881d475-4ff4-428f-92b6-590fffd7f312
📒 Files selected for processing (9)
yield-agentkit-skills/skills/yield-agentkit-privy/README.mdyield-agentkit-skills/skills/yield-agentkit-privy/SKILL.mdyield-agentkit-skills/skills/yield-agentkit-privy/references/architecture.mdyield-agentkit-skills/skills/yield-agentkit-privy/references/examples.mdyield-agentkit-skills/skills/yield-agentkit-privy/references/privy-policies.mdyield-agentkit-skills/skills/yield-agentkit-privy/references/privy-transactions.mdyield-agentkit-skills/skills/yield-agentkit-privy/references/privy-wallets.mdyield-agentkit-skills/skills/yield-agentkit-privy/references/semi-autonomous.mdyield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md
💤 Files with no reviewable changes (1)
- yield-agentkit-skills/skills/yield-agentkit-privy/references/privy-wallets.md
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md (1)
92-106:⚠️ Potential issue | 🟠 MajorUpdate schema field guidance to match new parameter interface.
Lines 92-106 describe the
mechanics.arguments.enterschema fields and state that field names should be "included in arguments_json" (line 96). However, the updatedactions_enterinterface (lines 180-181) no longer uses anarguments_jsonparameter—it now uses explicitamountand optionalargsparameters.Update this section to clarify how schema fields map to the new interface (e.g., required fields like
validatorAddressorinputTokenshould be passed in theargsobject).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md` around lines 92 - 106, Update the schema docs for mechanics.arguments.enter (ArgumentFieldDto) to map fields to the new actions_enter parameter interface: replace references to including field names in arguments_json with guidance that scalar fields (like validatorAddress, inputToken, etc.) should be provided inside the actions_enter args object and that amount remains a separate top-level parameter; keep the note that if optionsRef is present (e.g., validatorAddress) the client must call yields_get_validators to fetch valid options before invoking actions_enter.
🧹 Nitpick comments (1)
yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md (1)
180-181: Clarify whenargsfields are required.The
argsparameter documentation states it "May includevalidatorAddress(string),inputToken(string)," which suggests these are always optional. However, based on the schema inspection guidance (lines 92-105), some fields may be required depending on the yield's schema.Consider adding a note that references the schema inspection section, e.g., "See lines 92-105 for determining which fields are required based on the yield's enter schema."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md` around lines 180 - 181, Update the docs for the `args` field in the table row that lists `args` (and mentions `validatorAddress` and `inputToken`) to clarify that some `args` properties can be required depending on the yield's enter schema; reference the schema inspection guidance (lines 92-105) so readers know to consult that section to determine required vs optional fields.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md`:
- Line 120: The table currently lists the parameter `yieldId` as type `string[]`
but the API path `POST /v1/yields/{yieldId}/balances` and examples use a single
identifier; change the parameter type for `yieldId` from `string[]` to `string`
and update the description to "Unique yield identifier" to match usage (or, if
multiple IDs are intended, instead clarify the description and update the
endpoint/examples accordingly); ensure the `yieldId` entry in the parameters
table and any examples consistently reflect the chosen single-string type.
---
Outside diff comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md`:
- Around line 92-106: Update the schema docs for mechanics.arguments.enter
(ArgumentFieldDto) to map fields to the new actions_enter parameter interface:
replace references to including field names in arguments_json with guidance that
scalar fields (like validatorAddress, inputToken, etc.) should be provided
inside the actions_enter args object and that amount remains a separate
top-level parameter; keep the note that if optionsRef is present (e.g.,
validatorAddress) the client must call yields_get_validators to fetch valid
options before invoking actions_enter.
---
Nitpick comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md`:
- Around line 180-181: Update the docs for the `args` field in the table row
that lists `args` (and mentions `validatorAddress` and `inputToken`) to clarify
that some `args` properties can be required depending on the yield's enter
schema; reference the schema inspection guidance (lines 92-105) so readers know
to consult that section to determine required vs optional fields.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d1a2d915-3a6f-4bb4-9425-43b10253e72e
📒 Files selected for processing (1)
yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md (1)
180-181: Clarify whenargsfields are required and verify API compatibility.The
argsparameter documentation states "May includevalidatorAddress(string),inputToken(string)" but doesn't specify when these fields are needed. Consider adding guidance such as:
validatorAddress: Required when the yield's enter schema indicates validator selection (checkyields_getfor fields withoptionsRef)inputToken: Required when the yield accepts multiple input tokensAdditionally, since this represents a significant API change from the previous
arguments_jsonapproach (per the AI summary), verify that the MCP tool actually accepts this parameter structure.#!/bin/bash # Description: Verify the actions_enter parameter structure is documented consistently # Check for any OpenAPI/JSON schema definitions fd -e json -e yaml | xargs rg -l 'actions.*enter|enter.*action' | head -5 | xargs cat # Search for examples or usage of args parameter in actions_enter rg -n --type=md 'actions_enter' -A10 -B2 | rg -C5 'args|validatorAddress|inputToken'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md` around lines 180 - 181, The docs for the `args` parameter are ambiguous about when `validatorAddress` and `inputToken` are required and may not match the MCP tool's expected structure (replacing `arguments_json`); update the `args` row to explicitly state requirement conditions (e.g., "validatorAddress: required when the yield's enter schema indicates validator selection (see yields_get for fields with optionsRef)"; "inputToken: required when the yield accepts multiple input tokens") and add a short note that callers must pass `args` as an object in the actions_enter payload (verify compatibility with MCP by testing that actions_enter accepts the new `args` object format rather than the old `arguments_json`). Also run the suggested verification commands to confirm OpenAPI/JSON schemas and example usage align with this `args` shape and adjust the docs to match the actual MCP expectations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md`:
- Around line 206-209: The table in the actions_exit parameter docs incorrectly
marks validatorAddress and passthrough as simply "No"; update the "Required"
column for `validatorAddress` and `passthrough` to indicate conditional
requirement (e.g., "Conditional" or "Conditional*") and add a short footnote
explaining the condition: `validatorAddress` is required when the yield uses
validator selection and `passthrough` is required when the exit schema includes
it (reference how to check via `yields_get`); ensure the change mentions
`actions_exit`, `validatorAddress`, `passthrough`, and `yields_get` so readers
know where to check the schema.
- Line 189: Align transaction type casing between the docs by making the example
values match the canonical form in yield-mcp-tools.md: check the actual API
behavior and then update architecture.md so its example uses uppercase type
strings ("APPROVAL", "STAKE", "SUPPLY") instead of "approval"/"deposit" (replace
"deposit" with "SUPPLY" if that maps to the same API action), and update any
other examples that use lowercase types to the documented uppercase variants;
search for occurrences of "type": "approval", "type": "deposit", etc., and
normalize them to the canonical tokens or update yield-mcp-tools.md if the API
truly uses lowercase.
---
Nitpick comments:
In
`@yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md`:
- Around line 180-181: The docs for the `args` parameter are ambiguous about
when `validatorAddress` and `inputToken` are required and may not match the MCP
tool's expected structure (replacing `arguments_json`); update the `args` row to
explicitly state requirement conditions (e.g., "validatorAddress: required when
the yield's enter schema indicates validator selection (see yields_get for
fields with optionsRef)"; "inputToken: required when the yield accepts multiple
input tokens") and add a short note that callers must pass `args` as an object
in the actions_enter payload (verify compatibility with MCP by testing that
actions_enter accepts the new `args` object format rather than the old
`arguments_json`). Also run the suggested verification commands to confirm
OpenAPI/JSON schemas and example usage align with this `args` shape and adjust
the docs to match the actual MCP expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 331dd232-e142-42c6-bd31-6369afeda561
📒 Files selected for processing (1)
yield-agentkit-skills/skills/yield-agentkit-privy/references/yield-mcp-tools.md
Philippoes
requested review from
0xYoki,
apurvmishra,
dnehl,
jdomingos and
raiseerco
Philippoes
approved these changes
Apr 3, 2026
This was referenced Apr 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
yield-agentkit