Skip to content

Remove meta-vault redemptions - #729

Merged
evgeny-stakewise merged 3 commits into
v5-releasefrom
remove-meta-vaults-redemptions
May 22, 2026
Merged

Remove meta-vault redemptions#729
evgeny-stakewise merged 3 commits into
v5-releasefrom
remove-meta-vaults-redemptions

Conversation

@evgeny-stakewise

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes meta-vault redemption/distribution logic from the operator redemption flow, simplifying redemption asset calculation and ensuring the redeemer command no longer attempts any meta-vault-specific redemption operations.

Changes:

  • Stop distributing meta-vault redemption assets and remove related service/types/tests.
  • Remove meta-vault sub-vault redemption and meta-vault state-update handling from process-redeemer; meta-vault positions/vaults are now skipped.
  • Prune contract wrappers for removed meta-vault redemption/state-update calls.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/redemptions/tasks.py Removes meta-vault redemption asset distribution; returns direct per-vault assets.
src/meta_vault/typings.py Removes SubVaultRedemption typing.
src/meta_vault/tests/test_service.py Deletes tests for removed meta-vault redemption distribution behavior.
src/meta_vault/service.py Removes meta-vault redemption/state-update helpers; keeps is_meta_vault.
src/common/contracts.py Removes contract wrappers/methods used only for meta-vault redemption/state-update flows.
src/commands/tests/test_internal/test_process_redeemer.py Updates tests to assert meta-vaults are skipped and related logic is removed.
src/commands/internal/process_redeemer.py Skips meta-vaults in state updates and redemptions; removes sub-vault redemption flow and graph option.
Comments suppressed due to low confidence (1)

src/commands/internal/process_redeemer.py:360

  • redeem_positions() awaits is_meta_vault(position.vault) inside the per-position loop. Since is_meta_vault() makes an EL call on first encounter of a vault, large batches of positions with many unique vaults will incur many sequential RPC calls. Consider precomputing meta-vault status once per unique vault (or in parallel/batched) before iterating positions.
        shares_to_redeem = Wei(min(position.unprocessed_shares, remaining_shares))
        assets_to_redeem = converter.to_assets(shares_to_redeem)

        if await is_meta_vault(position.vault):
            continue


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands/internal/process_redeemer.py
Comment thread src/commands/internal/process_redeemer.py
@evgeny-stakewise
evgeny-stakewise merged commit e237467 into v5-release May 22, 2026
5 of 7 checks passed
@evgeny-stakewise
evgeny-stakewise deleted the remove-meta-vaults-redemptions branch May 22, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants