Remove meta-vault redemptions - #729
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes meta-vault redemption/distribution logic from the operator redemption flow, simplifying redemption asset calculation and ensuring the redeemer command no longer attempts any meta-vault-specific redemption operations.
Changes:
- Stop distributing meta-vault redemption assets and remove related service/types/tests.
- Remove meta-vault sub-vault redemption and meta-vault state-update handling from
process-redeemer; meta-vault positions/vaults are now skipped. - Prune contract wrappers for removed meta-vault redemption/state-update calls.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/redemptions/tasks.py | Removes meta-vault redemption asset distribution; returns direct per-vault assets. |
| src/meta_vault/typings.py | Removes SubVaultRedemption typing. |
| src/meta_vault/tests/test_service.py | Deletes tests for removed meta-vault redemption distribution behavior. |
| src/meta_vault/service.py | Removes meta-vault redemption/state-update helpers; keeps is_meta_vault. |
| src/common/contracts.py | Removes contract wrappers/methods used only for meta-vault redemption/state-update flows. |
| src/commands/tests/test_internal/test_process_redeemer.py | Updates tests to assert meta-vaults are skipped and related logic is removed. |
| src/commands/internal/process_redeemer.py | Skips meta-vaults in state updates and redemptions; removes sub-vault redemption flow and graph option. |
Comments suppressed due to low confidence (1)
src/commands/internal/process_redeemer.py:360
redeem_positions()awaitsis_meta_vault(position.vault)inside the per-position loop. Sinceis_meta_vault()makes an EL call on first encounter of a vault, large batches of positions with many unique vaults will incur many sequential RPC calls. Consider precomputing meta-vault status once per unique vault (or in parallel/batched) before iterating positions.
shares_to_redeem = Wei(min(position.unprocessed_shares, remaining_shares))
assets_to_redeem = converter.to_assets(shares_to_redeem)
if await is_meta_vault(position.vault):
continue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…in redeem_positions
cyc60
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.