Speedup graph_get_allocators - #732
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors graph_get_allocators to reduce the amount of allocator data fetched from the subgraph by first querying eligible redemption vaults (excluding legacy vaults and optionally meta vaults), then querying allocators per vault.
Changes:
- Split
graph_get_allocatorsintograph_get_redemption_vaults+graph_get_allocators_from_vaults. - Moved legacy/meta-vault filtering to the vaults query and added per-vault allocator querying with
mintedOsTokenShares_gt: 0. - Updated the redemptions graph unit test to exercise the new
graph_get_allocators_from_vaultsaggregation behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/redemptions/graph.py | Refactors allocator fetching into a 2-step vaults-then-allocators flow; adds new helper functions. |
| src/redemptions/tests/test_graph.py | Updates tests to target graph_get_allocators_from_vaults and validate aggregation across multiple vaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
There was a problem hiding this comment.
Refactored mocks here, because mocking 'fetch_pages' gets too hard. There are many fetch_pages calls inside graph_get_allocators. Added patch_graph_calls instead.
cyc60
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.